Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Color Brightness #73

Closed
arcticicestudio opened this issue May 8, 2019 · 0 comments · Fixed by #74
Closed

Comment Color Brightness #73

arcticicestudio opened this issue May 8, 2019 · 0 comments · Fixed by #74

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented May 8, 2019

Bound to nordtheme/nord#94

This issue will implement the increase of the comment color (nord3) brightness by 10% from a lightness level of ~35% to ~45%.

➜ Please see nordtheme/nord#94 for all details about this design change decision.

⚠️ NOTE: This will also deprecate the custom comment brightness configuration because it won't be necessary anymore for users to increase the brightness on their own.
A deprecation warning will be added to notify all users who have set a custom value for the nord-comment-brightness configuration variable.

@arcticicestudio arcticicestudio added this to the 0.4.0 milestone May 8, 2019
@arcticicestudio arcticicestudio self-assigned this May 8, 2019
@arcticicestudio arcticicestudio pinned this issue May 8, 2019
arcticicestudio added a commit that referenced this issue May 9, 2019
-> Please see nordtheme/nord#94 for all
   details about this design change decision.

Increased the comment color (`nord3`) brightness by 10% from a lightness
level of ~35% to ~45%.

This change also deprecates the custom comment brightness (1) configuration.
It is not necessary anymore for users to increase the brightness on
their own when the default color has been increased by default.
A deprecation/obsolete warning will be shown to notify all users who
have set a custom value for the `g:nord_comment_brightness`
configuration variable.

References:
  (1)  https://github.com/arcticicestudio/nord-emacs#custom-comment-brightness

GH-73
@arcticicestudio arcticicestudio removed their assignment May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant