Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove import of internal stuff #157

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Remove import of internal stuff #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/nomad_simulations/schema_packages/physical_property.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
SectionProxy,
SubSection,
)
from nomad.metainfo.metainfo import Dimension, DirectQuantity, _placeholder_quantity
from nomad.metainfo.metainfo import Dimension

if TYPE_CHECKING:
from nomad.datamodel.datamodel import EntryArchive
Expand Down Expand Up @@ -120,7 +120,7 @@ class PhysicalProperty(ArchiveSection):
# ! add more examples in the description to improve the understanding of this quantity
)

rank = DirectQuantity(
rank = Quantity(
type=Dimension,
shape=['0..*'],
default=[],
Expand All @@ -137,7 +137,7 @@ class PhysicalProperty(ArchiveSection):
variables = SubSection(sub_section=Variables.m_def, repeats=True)

# * `value` must be overwritten in the derived classes defining its type, unit, and description
value: Quantity = _placeholder_quantity
value: Quantity = None

entity_ref = Quantity(
type=Entity,
Expand Down
Loading