Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove import of internal stuff #157

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Remove import of internal stuff #157

merged 1 commit into from
Dec 11, 2024

Conversation

TLCFEM
Copy link
Contributor

@TLCFEM TLCFEM commented Dec 11, 2024

No description provided.

@TLCFEM TLCFEM requested a review from ndaelman-hu December 11, 2024 03:54
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12269347710

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.147%
Totals Coverage Status
Change from base Build 11890140918: 0.0%
Covered Lines: 2075
Relevant Lines: 2589
💛 - Coveralls

@TLCFEM
Copy link
Contributor Author

TLCFEM commented Dec 11, 2024

@ndaelman-hu Please merge at your convenience.

ndaelman-hu
ndaelman-hu approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@ndaelman-hu ndaelman-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for administiring these changes.
Soon enough, we'll also scrap this implementation of PhysicalProperty for Markus'.
It's good that these deprecated classes are gone meanwhile.

@ndaelman-hu ndaelman-hu merged commit 0c0caad into develop Dec 11, 2024
7 checks passed
@ndaelman-hu ndaelman-hu deleted the remove-dependency-of-placeholder branch December 11, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndaelman-hu ndaelman-hu ndaelman-hu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TLCFEM @coveralls @ndaelman-hu