Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from aztec-packages #6210

Merged
merged 9 commits into from
Oct 2, 2024
Merged

feat: Sync from aztec-packages #6210

merged 9 commits into from
Oct 2, 2024

Conversation

AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented Oct 2, 2024

Automated pull of Noir development from aztec-packages.
BEGIN_COMMIT_OVERRIDE
fix: Databus panic for fns with empty params (AztecProtocol/aztec-packages#8847)
END_COMMIT_OVERRIDE

AztecBot and others added 9 commits October 2, 2024 22:43
* master: (36 commits)
  fix: ignore compression of blocks after msg.len in sha256_var (#6206)
  feat(perf): Optimize array set from get (#6207)
  chore(refactor): Array set optimization context struct for analysis (#6204)
  fix: type variables by default should have Any kind (#6203)
  feat: remove orphaned blocks from cfg to improve `simplify_cfg` pass. (#6198)
  fix(ssa): Check if result of array set is used in value of another array set (#6197)
  fix(docs): Rename recursion.md to recursion.mdx (#6195)
  feat: skip `remove_enable_side_effects` pass on brillig functions (#6199)
  feat!: Syncing TypeVariableKind with Kind (#6094)
  feat(perf): Simplify the cfg after DIE (#6184)
  feat: refactor SSA passes to run on individual functions (#6072)
  chore: Remove macros_api module (#6190)
  fix: ensure to_bytes returns the canonical decomposition (#6084)
  chore: rename `DefinitionKind::GenericType` (#6182)
  feat(perf): Remove redundant inc rc without instructions between (#6183)
  chore: reexport `CrateName` through `nargo` (#6177)
  feat(perf): Remove inc_rc instructions for arrays which are never mutably borrowed (#6168)
  chore(docs): Add link to more info about proving backend to Solidity verifier page (#5754)
  feat: let `Module::functions` and `Module::structs` return them in definition order (#6178)
  chore: split `test_program`s into modules (#6101)
  ...
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Changes to Brillig bytecode sizes

Generated at commit: 6e664a3cccafdeb4def02cf5ee8400852dcf3086, compared to commit: 76eec710ff73e5e45fdddcd41ae2cd74e879cfa5

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
pedersen_hash +363 ❌ +1344.44%
pedersen_check +361 ❌ +189.01%
brillig_pedersen +361 ❌ +189.01%

Full diff report 👇
Program Brillig opcodes (+/-) %
pedersen_hash 390 (+363) +1344.44%
pedersen_check 552 (+361) +189.01%
brillig_pedersen 552 (+361) +189.01%
simple_shield 654 (+360) +122.45%
merkle_insert 1,336 (+612) +84.53%
schnorr 1,498 (+621) +70.81%
brillig_cow_regression 2,336 (+367) +18.64%
aes128_encrypt 511 (+52) +11.33%

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Changes to circuit sizes

Generated at commit: 6e664a3cccafdeb4def02cf5ee8400852dcf3086, compared to commit: 76eec710ff73e5e45fdddcd41ae2cd74e879cfa5

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
merkle_insert +24 ❌ +1.35% 0 ➖ 0.00%
pedersen_check +4 ❌ +10.53% 0 ➖ 0.00%
pedersen_hash +4 ❌ +200.00% 0 ➖ 0.00%
schnorr +12 ❌ +0.68% 0 ➖ 0.00%
simple_shield +12 ❌ +24.49% 0 ➖ 0.00%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
merkle_insert 1,803 (+24) +1.35% 29,032 (0) 0.00%
pedersen_check 42 (+4) +10.53% 28,858 (0) 0.00%
pedersen_hash 6 (+4) +200.00% 28,742 (0) 0.00%
schnorr 1,775 (+12) +0.68% 54,388 (0) 0.00%
simple_shield 61 (+12) +24.49% 29,032 (0) 0.00%

@TomAFrench TomAFrench added this pull request to the merge queue Oct 2, 2024
Merged via the queue into master with commit d252748 Oct 2, 2024
47 checks passed
@TomAFrench TomAFrench deleted the aztec-packages branch October 2, 2024 23:26
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 3, 2024
chore: revert mistaken stack size change (noir-lang/noir#6212)
chore: fix typo in code snippet (noir-lang/noir#6211)
feat: Sync from aztec-packages (noir-lang/noir#6210)
fix: ignore compression of blocks after msg.len in sha256_var (noir-lang/noir#6206)
feat(perf): Optimize array set from get (noir-lang/noir#6207)
chore(refactor): Array set optimization context struct for analysis (noir-lang/noir#6204)
fix: type variables by default should have Any kind (noir-lang/noir#6203)
feat: remove orphaned blocks from cfg to improve `simplify_cfg` pass. (noir-lang/noir#6198)
fix(ssa): Check if result of array set is used in value of another array set (noir-lang/noir#6197)
fix(docs): Rename recursion.md to recursion.mdx (noir-lang/noir#6195)
feat: skip `remove_enable_side_effects` pass on brillig functions (noir-lang/noir#6199)
feat!: Syncing TypeVariableKind with Kind (noir-lang/noir#6094)
feat(perf): Simplify the cfg after DIE (noir-lang/noir#6184)
feat: refactor SSA passes to run on individual functions (noir-lang/noir#6072)
chore: Remove macros_api module (noir-lang/noir#6190)
fix: ensure to_bytes returns the canonical decomposition (noir-lang/noir#6084)
chore: rename `DefinitionKind::GenericType` (noir-lang/noir#6182)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 3, 2024
chore: revert mistaken stack size change (noir-lang/noir#6212)
chore: fix typo in code snippet (noir-lang/noir#6211)
feat: Sync from aztec-packages (noir-lang/noir#6210)
fix: ignore compression of blocks after msg.len in sha256_var (noir-lang/noir#6206)
feat(perf): Optimize array set from get (noir-lang/noir#6207)
chore(refactor): Array set optimization context struct for analysis (noir-lang/noir#6204)
fix: type variables by default should have Any kind (noir-lang/noir#6203)
feat: remove orphaned blocks from cfg to improve `simplify_cfg` pass. (noir-lang/noir#6198)
fix(ssa): Check if result of array set is used in value of another array set (noir-lang/noir#6197)
fix(docs): Rename recursion.md to recursion.mdx (noir-lang/noir#6195)
feat: skip `remove_enable_side_effects` pass on brillig functions (noir-lang/noir#6199)
feat!: Syncing TypeVariableKind with Kind (noir-lang/noir#6094)
feat(perf): Simplify the cfg after DIE (noir-lang/noir#6184)
feat: refactor SSA passes to run on individual functions (noir-lang/noir#6072)
chore: Remove macros_api module (noir-lang/noir#6190)
fix: ensure to_bytes returns the canonical decomposition (noir-lang/noir#6084)
chore: rename `DefinitionKind::GenericType` (noir-lang/noir#6182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants