chore: Release Noir(0.35.0) (noir-lang/noir#6030)

chore: revert mistaken stack size change (noir-lang/noir#6212)
chore: fix typo in code snippet (noir-lang/noir#6211)
feat: Sync from aztec-packages (noir-lang/noir#6210)
fix: ignore compression of blocks after msg.len in sha256_var (noir-lang/noir#6206)
feat(perf): Optimize array set from get (noir-lang/noir#6207)
chore(refactor): Array set optimization context struct for analysis (noir-lang/noir#6204)
fix: type variables by default should have Any kind (noir-lang/noir#6203)
feat: remove orphaned blocks from cfg to improve `simplify_cfg` pass. (noir-lang/noir#6198)
fix(ssa): Check if result of array set is used in value of another array set (noir-lang/noir#6197)
fix(docs): Rename recursion.md to recursion.mdx (noir-lang/noir#6195)
feat: skip `remove_enable_side_effects` pass on brillig functions (noir-lang/noir#6199)
feat!: Syncing TypeVariableKind with Kind (noir-lang/noir#6094)
feat(perf): Simplify the cfg after DIE (noir-lang/noir#6184)
feat: refactor SSA passes to run on individual functions (noir-lang/noir#6072)
chore: Remove macros_api module (noir-lang/noir#6190)
fix: ensure to_bytes returns the canonical decomposition (noir-lang/noir#6084)
chore: rename `DefinitionKind::GenericType` (noir-lang/noir#6182)

.circleci/config.yml

@@ -613,7 +613,4 @@ workflows:
  - barretenberg-docs
  - e2e-join
  - cli-wallet
- <<: *defaults
-
- # Production releases.
- - deploy-and-release: *defaults_deploy
+ <<: *defaults

.github/earthly-ci-config.yml

@@ -1,5 +1,5 @@
 global:
  cache_size_pct: 50
- buildkit_max_parallelism: 5
+ buildkit_max_parallelism: 10
  container_frontend: docker-shell
 buildkit_additional_args: ["-e", "BUILDKIT_STEP_LOG_MAX_SIZE=-1"]

.github/workflows/ci.yml

@@ -118,7 +118,8 @@ jobs:
 
  build:
  needs: [build-images, changes]
- if: (needs.changes.outputs.non-docs == 'true' && needs.changes.outputs.non-misc-ci == 'true' && needs.changes.outputs.non-barretenberg-cpp == 'true') || github.ref_name == 'master'
+ # NOTE: we don't skip this job here instead using if's below so that dependencies are not broken
+ # we still want build to be at the bottom of the dependency chain
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  outputs:
  e2e_list: ${{ steps.e2e_list.outputs.list }}
@@ -132,6 +133,7 @@ jobs:
  # prepare images locally, tagged by commit hash
  - name: "Build E2E Image"
  timeout-minutes: 40
+ if: (needs.changes.outputs.non-docs == 'true' && needs.changes.outputs.non-misc-ci == 'true' && needs.changes.outputs.non-barretenberg-cpp == 'true') || github.ref_name == 'master'
  run: |
  earthly-ci ./yarn-project+export-e2e-test-images
  # We base our e2e list used in e2e-x86 off the targets in ./yarn-project/end-to-end
@@ -160,7 +162,7 @@ jobs:
  # all the non-bench end-to-end integration tests for aztec
  e2e:
  needs: [build, changes]
- if: needs.changes.outputs.non-barretenberg-cpp == 'true' || github.ref_name == 'master' || contains(github.event.pull_request.labels.*.name, 'e2e')
+ if: (needs.changes.outputs.non-docs == 'true' && needs.changes.outputs.non-misc-ci == 'true' && needs.changes.outputs.non-barretenberg-cpp == 'true') || github.ref_name == 'master' || contains(github.event.pull_request.labels.*.name, 'e2e')
  runs-on: ubuntu-20.04
  strategy:
  fail-fast: false
@@ -190,7 +192,7 @@ jobs:
  # all the benchmarking end-to-end integration tests for aztec (not required to merge)
  bench-e2e:
  needs: [build, changes]
- if: needs.changes.outputs.non-barretenberg-cpp == 'true' || github.ref_name == 'master' || contains(github.event.pull_request.labels.*.name, 'bench')
+ if: (needs.changes.outputs.non-docs == 'true' && needs.changes.outputs.non-misc-ci == 'true' && needs.changes.outputs.non-barretenberg-cpp == 'true') || github.ref_name == 'master' || contains(github.event.pull_request.labels.*.name, 'bench')
  runs-on: ubuntu-20.04
  strategy:
  fail-fast: false
@@ -221,7 +223,7 @@ jobs:
 
  acir-bench:
  runs-on: ubuntu-20.04
- needs: [build-images, changes]
+ needs: [build, changes]
  # Note: not fully accurate, but to work with bench-summary needs to be the same as bench-e2e
  if: needs.changes.outputs.non-barretenberg-cpp == 'true'
  steps:
@@ -258,7 +260,6 @@ jobs:
  ref: "${{ github.event.pull_request.head.sha }}"
  - uses: ./.github/ci-setup-action
  with:
- dockerhub_password: "${{ secrets.DOCKERHUB_PASSWORD }}"
  concurrency_key: build-x86
  - name: "Build and upload bench aggregate file"
  working-directory: ./yarn-project/scripts
@@ -286,7 +287,7 @@ jobs:
  AZTEC_BOT_GITHUB_TOKEN: ${{ secrets.AZTEC_BOT_GITHUB_TOKEN }}
 
  bb-gcc:
- needs: [build-images, changes]
+ needs: [build, changes]
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  if: needs.changes.outputs.barretenberg-cpp == 'true'
  steps:
@@ -306,7 +307,7 @@ jobs:
  # barretenberg (prover) native, AVM (public VM) and Merkle tree (world state) tests
  # only ran on x86 for resource reasons (memory intensive)
  bb-native-tests:
- needs: [build-images, changes]
+ needs: [build, changes]
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  if: needs.changes.outputs.barretenberg-cpp == 'true'
  steps:
@@ -324,7 +325,7 @@ jobs:
  run: earthly-ci --exec-stats --no-output +test --hardware_concurrency=64
 
  bb-js-test:
- needs: [build-images, changes]
+ needs: [build, changes]
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  if: needs.changes.outputs.barretenberg == 'true'
  steps:
@@ -339,7 +340,7 @@ jobs:
  run: earthly-ci --no-output ./+test
 
  noir-build-acir-tests:
- needs: [build-images, changes]
+ needs: [build, changes]
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  if: needs.changes.outputs.barretenberg == 'true' || needs.changes.outputs.noir == 'true'
  steps:
@@ -413,7 +414,7 @@ jobs:
  run: earthly-ci --no-output ./+barretenberg-acir-tests-bb.js
 
  noir-format:
- needs: [build-images, changes]
+ needs: [build, changes]
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  if: needs.changes.outputs.noir == 'true' || needs.changes.outputs.noir-projects == 'true'
  steps:
@@ -433,7 +434,7 @@ jobs:
  earthly-ci --no-output ./+format
 
  noir-test:
- needs: [build-images, changes]
+ needs: [build, changes]
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  if: needs.changes.outputs.noir == 'true'
  steps:
@@ -446,7 +447,7 @@ jobs:
  run: earthly-ci --no-output ./noir+test
 
  noir-examples:
- needs: [build-images, changes]
+ needs: [build, changes]
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  if: needs.changes.outputs.barretenberg == 'true' || needs.changes.outputs.noir == 'true'
  steps:
@@ -459,7 +460,7 @@ jobs:
  run: earthly-ci --no-output ./noir+examples
 
  noir-packages-test:
- needs: [build-images, changes]
+ needs: [build, changes]
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  if: needs.changes.outputs.barretenberg == 'true' || needs.changes.outputs.noir == 'true'
  steps:
@@ -473,7 +474,7 @@ jobs:
  run: earthly-ci --no-output ./noir+packages-test
 
  noir-projects:
- needs: [build-images, changes, build]
+ needs: [build, changes, build]
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  if: needs.changes.outputs.barretenberg == 'true' || needs.changes.outputs.noir == 'true' || needs.changes.outputs.noir-projects == 'true' || needs.changes.outputs.txe == 'true'
  steps:
@@ -488,7 +489,7 @@ jobs:
  earthly-ci --no-output ./noir-projects/+test
 
  avm-format:
- needs: [build-images, changes]
+ needs: [build, changes]
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  if: needs.changes.outputs.avm-transpiler == 'true' || needs.changes.outputs.noir == 'true'
  steps:
@@ -542,7 +543,7 @@ jobs:
  run: earthly-ci --no-output ./yarn-project/+prover-client-test
 
  l1-contracts-test:
- needs: [build-images, changes]
+ needs: [build, changes]
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  if: needs.changes.outputs.l1-contracts == 'true'
  steps:
@@ -555,7 +556,7 @@ jobs:
  run: earthly-ci --no-output ./l1-contracts+test
 
  docs-preview:
- needs: [build-images, changes]
+ needs: [build, changes]
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  if: needs.changes.outputs.non-barretenberg-cpp == 'true'
  steps:
@@ -576,7 +577,7 @@ jobs:
 
  bb-bench:
  runs-on: ubuntu-20.04
- needs: [build-images, changes]
+ needs: [build, changes]
  if: needs.changes.outputs.barretenberg-cpp == 'true'
  steps:
  - uses: actions/checkout@v4
@@ -661,7 +662,7 @@ jobs:
  run: earthly-ci -P --no-output +test --box=${{ matrix.box }} --browser=${{ matrix.browser }} --mode=cache
 
  protocol-circuits-gates-report:
- needs: [build-images, changes]
+ needs: [build, changes]
  if: needs.changes.outputs.non-docs == 'true' && needs.changes.outputs.non-misc-ci == 'true'
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  permissions:
@@ -697,7 +698,7 @@ jobs:
  message: ${{ steps.gates_diff.outputs.markdown }}
 
  public-functions-size-report:
- needs: [build-images, changes]
+ needs: [build, changes]
  if: needs.changes.outputs.non-docs == 'true' && needs.changes.outputs.non-misc-ci == 'true'
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  permissions:
@@ -719,7 +720,7 @@ jobs:
 
  - name: Compare public functions bytecode size reports
  id: public_functions_sizes_diff
- uses: noir-lang/noir-gates-diff@ef8aaf48fb833f3b6e3f91665bb23afb7e68c6e3
+ uses: noir-lang/noir-gates-diff@d88f7523b013b9edd3f31c5cfddaef87a3fe1b48
  with:
  report: public_functions_report.json
  header: |

.github/workflows/spartan-test.yml → .github/workflows/nightly-kind-test.yml

@@ -1,4 +1,4 @@
-name: Run spartan network tests
+name: KIND network tests
 on:
  workflow_dispatch:
  schedule:
@@ -9,10 +9,18 @@ concurrency:
  cancel-in-progress: true
 
 env:
- DOCKERHUB_PASSWORD: ${{ secrets.DOCKERHUB_PASSWORD }}
- GIT_COMMIT: ${{ github.sha }}
+ DOCKERHUB_PASSWORD: "${{ secrets.DOCKERHUB_PASSWORD }}"
+ RUN_ID: ${{ github.run_id }}
+ RUN_ATTEMPT: ${{ github.run_attempt }}
+ USERNAME: ${{ github.event.pull_request.user.login || github.actor }}
+ GITHUB_TOKEN: ${{ github.token }}
+ GH_SELF_HOSTED_RUNNER_TOKEN: ${{ secrets.GH_SELF_HOSTED_RUNNER_TOKEN }}
  AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
  AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+ BUILD_INSTANCE_SSH_KEY: ${{ secrets.BUILD_INSTANCE_SSH_KEY }}
+ GIT_COMMIT: ${{ github.event.pull_request.head.sha || github.sha }}
+ # kludge until we move away from runners
+ WAIT_FOR_RUNNERS: false
 
 jobs:
  setup:
@@ -22,79 +30,8 @@ jobs:
  runner_type: builder-x86
  secrets: inherit
 
- changes:
- runs-on: ubuntu-20.04
- # Required permissions.
- permissions:
- pull-requests: read
- # Set job outputs to values from filter step
- outputs:
- avm-transpiler: ${{ steps.filter.outputs.avm-transpiler }}
- build-images: ${{ steps.filter.outputs.build-images }}
- barretenberg: ${{ steps.filter.outputs.barretenberg }}
- barretenberg-cpp: ${{ steps.filter.outputs.barretenberg-cpp }}
- noir: ${{ steps.filter.outputs.noir }}
- noir-projects: ${{ steps.filter.outputs.noir-projects }}
- l1-contracts: ${{ steps.filter.outputs.l1-contracts }}
- non-docs: ${{ steps.filter.outputs.non-docs }}
- non-misc-ci: ${{ steps.filter.outputs.non-misc-ci }}
- non-barretenberg-cpp: ${{ steps.filter.outputs.non-barretenberg-cpp }}
- steps:
- - uses: actions/checkout@v4
- with: { ref: "${{ env.GIT_COMMIT }}" }
- - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36
- id: filter
- with:
- filters: |
- barretenberg:
- - 'barretenberg/**'
- barretenberg-cpp:
- - 'barretenberg/cpp/**'
- build-images:
- - 'build-images/**'
- noir:
- - 'noir/**'
- avm-transpiler:
- - 'avm-transpiler/**'
- l1-contracts:
- - 'l1-contracts/**'
- noir-projects:
- - 'noir-projects/**'
- non-barretenberg-cpp:
- - '!(barretenberg/cpp/**)'
- # don't consider AVM stuff 'core bb'
- - barretenberg/cpp/pil/**
- - barretenberg/cpp/src/barretenberg/vm/**
- - barretenberg/cpp/src/barretenberg/**/generated/*
- - barretenberg/cpp/src/barretenberg/client_ivc.{hpp,cpp}
- non-docs:
- - '!(docs/**)'
- non-misc-ci:
- - '!(.github/**)'
- # Always rebuild when this file changes
- - .github/workflows/ci.yml
-
- build-images:
- needs: [setup, changes]
- # Note we don't but the 'if' here as that would also apply to dependent jobs, instead we just copy it into each step
- runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
- steps:
- - uses: actions/checkout@v4
- if: ${{ needs.changes.outputs.build-images == 'true' }}
- with: { ref: "${{ env.GIT_COMMIT }}" }
- - uses: ./.github/ci-setup-action
- if: ${{ needs.changes.outputs.build-images == 'true' }}
- with:
- concurrency_key: build-images-x86
- - name: "Push Build Images If Changed"
- if: ${{ needs.changes.outputs.build-images == 'true' }}
- timeout-minutes: 40
- run: |
- earthly-ci --push ./build-images/+build
-
  build:
- needs: [build-images, changes]
- if: ${{ needs.changes.outputs.non-docs == 'true' && needs.changes.outputs.non-misc-ci == 'true' && needs.changes.outputs.non-barretenberg-cpp == 'true' }}
+ needs: setup
  runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
  outputs:
  e2e_list: ${{ steps.e2e_list.outputs.list }}
@@ -112,8 +49,7 @@ jobs:
  earthly-ci ./yarn-project+export-e2e-test-images
 
  test:
- needs: [build, changes]
- if: ${{ needs.changes.outputs.non-barretenberg-cpp == 'true' }}
+ needs: build
  runs-on: ubuntu-20.04
  strategy:
  matrix: