Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: migrate String::Value to String::ValueView #55458

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

RedYetiDev
Copy link
Member

Fixes #54417
Ref: #55452

v8::String::Value is deprecated, so this PR replaces it with v8::String::ValueView

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 19, 2024
@RedYetiDev RedYetiDev mentioned this pull request Oct 19, 2024
7 tasks
@RedYetiDev RedYetiDev added needs-citgm PRs that need a CITGM CI run. needs-benchmark-ci PR that need a benchmark CI run. labels Oct 19, 2024
@RedYetiDev
Copy link
Member Author

I've added needs-benchmark-ci PR that need a benchmark CI run. in case this slows / speeds things up / down

I've also added needs-citgm PRs that need a CITGM CI run. as a "just-in-case", as this modifies very important code (E.G. Buffer's IndexOf), and it would be unfortunate if it breaks something we were unaware of.

@RedYetiDev RedYetiDev changed the title src:: migrate String::Value to String::ValueView src: migrate String::Value to String::ValueView Oct 19, 2024
src/node_buffer.cc Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (8ed50bc) to head (fdc94c9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/string_bytes.cc 20.00% 8 Missing ⚠️
src/node_buffer.cc 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55458   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files         653      653           
  Lines      187485   187488    +3     
  Branches    36095    36090    -5     
=======================================
+ Hits       165764   165768    +4     
+ Misses      14966    14965    -1     
  Partials     6755     6755           
Files with missing lines Coverage Δ
src/inspector_js_api.cc 86.39% <100.00%> (+0.10%) ⬆️
src/node_buffer.cc 70.53% <92.85%> (+0.17%) ⬆️
src/string_bytes.cc 67.98% <20.00%> (-0.46%) ⬇️

... and 24 files with indirect coverage changes

src/inspector_js_api.cc Outdated Show resolved Hide resolved
src/node_buffer.cc Outdated Show resolved Hide resolved
src/node_buffer.cc Outdated Show resolved Hide resolved
Copy link
Member

@vmoroz vmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RedYetiDev RedYetiDev added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v8::String::Value is deprecated
4 participants