You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
RedYetiDev opened this issue
Oct 18, 2024
· 1 comment
Labels
c++Issues and PRs that require attention from people who are familiar with C++.deprecationsIssues and PRs related to deprecations.v8 engineIssues and PRs related to the V8 dependency.
Another PR is updated V8 to 13.0, so I compiled a list of deprecations from that version onward. While they don't need to be fixed immediately, it's important to know they exist.
template<class T> struct v8::FastApiTypedArray
Reason: When an API function expects a TypedArray as a parameter, the type in the signature should be v8::Local<v8::Value> instead of FastApiTypedArray<>.
Action: Type-check the parameter and convert it to v8::Local<v8::TypedArray> to access the data. Handle the parameter the same way as for a regular API call.
Details:
‘template<class T> struct v8::FastApiTypedArray’ is deprecated:
When an API function expects a TypedArray as a parameter,
the type in the signature should be `v8::Local<v8::Value>` instead of FastApiTypedArray<>.
The API function then has to type-check the parameter and convert it to a `v8::Local<v8::TypedArray` to access the data.
In essence, the parameter should be handled the same as for a regular API call.
‘v8::Local<v8::Value> v8::Object::GetPrototype()’ is deprecated:
V8 will stop providing access to hidden prototype (i.e. JSGlobalObject).
Use GetPrototypeV2() instead. See http://crbug.com/333672197.
‘v8::Maybe<bool> v8::Object::SetPrototype(v8::Local<v8::Context>, v8::Local<v8::Value>)’ is deprecated:
V8 will stop providing access to hidden prototype (i.e. JSGlobalObject).
Use SetPrototypeV2() instead. See http://crbug.com/333672197.
Reason: Deprecated in favor of a version that passes CreateParams.
Action: Use the version that passes CreateParams.
Details:
‘v8::SnapshotCreator::SnapshotCreator(v8::Isolate*, const intptr_t*, const v8::StartupData*, bool)’ is deprecated:
Use the version that passes CreateParams instead.
Reason: Prefer alternatives for better performance.
Action: Use String::ValueView if possible, or use string->Write to a buffer if not.
Details:
‘v8::String::Value::Value(v8::Isolate*, v8::Local<v8::Value>)’ is deprecated:
Prefer using String::ValueView if you can, or string->Write to a buffer if you cannot.
void v8::Isolate::AttachCppHeap(v8::CppHeap*)
Reason: Set the heap on Isolate creation.
Action: Use CreateParams instead.
Details:
‘void v8::Isolate::AttachCppHeap(v8::CppHeap*)’ is deprecated:
Set the heap on Isolate creation using CreateParams instead.
void v8::Isolate::DetachCppHeap()
Reason: Set the heap on Isolate creation.
Action: Use CreateParams instead.
Details:
‘void v8::Isolate::DetachCppHeap()’ is deprecated:
Set the heap on Isolate creation using CreateParams instead.
The text was updated successfully, but these errors were encountered:
RedYetiDev
added
c++
Issues and PRs that require attention from people who are familiar with C++.
v8 engine
Issues and PRs related to the V8 dependency.
deprecations
Issues and PRs related to deprecations.
labels
Oct 18, 2024
* [ ] **`v8::SnapshotCreator::SnapshotCreator(v8::Isolate*, const intptr_t*, const v8::StartupData*, bool)`**
* **Reason**: Deprecated in favor of a version that passes `CreateParams`.
* **Action**: Use the version that passes `CreateParams`.
* **Details**:
```
‘v8::SnapshotCreator::SnapshotCreator(v8::Isolate*, const intptr_t*, const v8::StartupData*, bool)’ is deprecated:
Use the version that passes CreateParams instead.
```
c++Issues and PRs that require attention from people who are familiar with C++.deprecationsIssues and PRs related to deprecations.v8 engineIssues and PRs related to the V8 dependency.
Another PR is updated V8 to 13.0, so I compiled a list of deprecations from that version onward. While they don't need to be fixed immediately, it's important to know they exist.
template<class T> struct v8::FastApiTypedArray
v8::Local<v8::Value>
instead ofFastApiTypedArray<>
.v8::Local<v8::TypedArray>
to access the data. Handle the parameter the same way as for a regular API call.v8::Local<v8::Value> v8::Object::GetPrototype()
(src: switch fromGet/SetPrototype
toGet/SetPrototypeV2
#55453)GetPrototypeV2()
instead.v8::Maybe<bool> v8::Object::SetPrototype(v8::Local<v8::Context>, v8::Local<v8::Value>)
(src: switch fromGet/SetPrototype
toGet/SetPrototypeV2
#55453)SetPrototypeV2()
instead.v8::SnapshotCreator::SnapshotCreator(v8::Isolate*, const intptr_t*, const v8::StartupData*, bool)
(src: migrate from deprecated SnapshotCreator constructor #55337)CreateParams
.CreateParams
.v8::String::Value::Value(v8::Isolate*, v8::Local<v8::Value>)
String::ValueView
if possible, or usestring->Write
to a buffer if not.void v8::Isolate::AttachCppHeap(v8::CppHeap*)
CreateParams
instead.void v8::Isolate::DetachCppHeap()
CreateParams
instead.The text was updated successfully, but these errors were encountered: