Apply suggestions from code review

nodejs · Oct 17, 2024 · cc94eb5 · cc94eb5
1 parent 3c86c25
commit cc94eb5
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/test/parallel/test-find-package-json.js b/test/parallel/test-find-package-json.js
@@ -83,16 +83,16 @@ describe('findPackageJSON', () => { // Throws when no arguments are provided
 
  const readPJSON = (locus) => JSON.parse(fs.readFileSync(locus, 'utf8'));
 
- const { secretNumberRoot } = readPJSON(findPackageJSON('pkg', import.meta.url));
- let secretNumberSubfolder; // Impossible to resolve because pkg's pjson.exports blocks access
- try { ({ secretNumberSubfolder } = findPackageJSON('pkg/subfolder/', import.meta.url)) } catch {}
+ const { secretNumberSubfolder } = readPJSON(findPackageJSON('pkg', import.meta.url));
+ let secretNumberPkgRoot; // Impossible to resolve because pkg's pjson.exports blocks access
+ try { ({ secretNumberPkgRoot } = findPackageJSON('pkg/subfolder/', import.meta.url)) } catch {}
  const { secretNumberSubfolder2 } = readPJSON(findPackageJSON('pkg2', import.meta.url));
  const { secretNumberPkg2 } = readPJSON(findPackageJSON('pkg2/package.json', import.meta.url));
 
  console.log(secretNumberRoot, secretNumberSubfolder, secretNumberSubfolder2, secretNumberPkg2);
  `);
 
- const secretNumberRoot = Math.ceil(Math.random() * 999);
+ const secretNumberPkgRoot = Math.ceil(Math.random() * 999);
  const secretNumberSubfolder = Math.ceil(Math.random() * 999);
  const secretNumberSubfolder2 = Math.ceil(Math.random() * 999);
  const secretNumberPkg2 = Math.ceil(Math.random() * 999);
@@ -106,15 +106,15 @@ describe('findPackageJSON', () => { // Throws when no arguments are provided
  tmpdir.resolve('node_modules/pkg/subfolder/package.json'),
  JSON.stringify({
  type: 'module',
- secretNumberRoot,
+ secretNumberSubfolder,
  }),
  );
  fs.writeFileSync(
  tmpdir.resolve('node_modules/pkg/package.json'),
  JSON.stringify({
  name: 'pkg',
  exports: './subfolder/index.js',
- secretNumberSubfolder,
+ secretNumberPkgRoot,
  }),
  );