Skip to content

Commit

Permalink
fixup!: rename test various for clarity
Browse files Browse the repository at this point in the history
  • Loading branch information
JakobJingleheimer committed Oct 17, 2024
1 parent debf4c6 commit 3c86c25
Showing 1 changed file with 16 additions and 17 deletions.
33 changes: 16 additions & 17 deletions test/parallel/test-find-package-json.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,20 +83,19 @@ describe('findPackageJSON', () => { // Throws when no arguments are provided
const readPJSON = (locus) => JSON.parse(fs.readFileSync(locus, 'utf8'));
const { secretNumber1 } = readPJSON(findPackageJSON('pkg', import.meta.url));
// This is impossible to resolve because pkg's pjson.exports blocks access
let secretNumber2Location = NaN;
try { secretNumber2Location = findPackageJSON('pkg/subfolder/', import.meta.url) } catch {}
const { secretNumber3 } = readPJSON(findPackageJSON('pkg2', import.meta.url));
const { secretNumber4 } = readPJSON(findPackageJSON('pkg2/package.json', import.meta.url));
console.log(secretNumber1, secretNumber2Location, secretNumber3, secretNumber4);
const { secretNumberRoot } = readPJSON(findPackageJSON('pkg', import.meta.url));
let secretNumberSubfolder; // Impossible to resolve because pkg's pjson.exports blocks access
try { ({ secretNumberSubfolder } = findPackageJSON('pkg/subfolder/', import.meta.url)) } catch {}
const { secretNumberSubfolder2 } = readPJSON(findPackageJSON('pkg2', import.meta.url));
const { secretNumberPkg2 } = readPJSON(findPackageJSON('pkg2/package.json', import.meta.url));
console.log(secretNumberRoot, secretNumberSubfolder, secretNumberSubfolder2, secretNumberPkg2);
`);

const secretNumber1 = Math.ceil(Math.random() * 999);
const secretNumber2 = Math.ceil(Math.random() * 999);
const secretNumber3 = Math.ceil(Math.random() * 999);
const secretNumber4 = Math.ceil(Math.random() * 999);
const secretNumberRoot = Math.ceil(Math.random() * 999);
const secretNumberSubfolder = Math.ceil(Math.random() * 999);
const secretNumberSubfolder2 = Math.ceil(Math.random() * 999);
const secretNumberPkg2 = Math.ceil(Math.random() * 999);

fs.mkdirSync(tmpdir.resolve('node_modules/pkg/subfolder'), { recursive: true });
fs.writeFileSync(
Expand All @@ -107,15 +106,15 @@ describe('findPackageJSON', () => { // Throws when no arguments are provided
tmpdir.resolve('node_modules/pkg/subfolder/package.json'),
JSON.stringify({
type: 'module',
secretNumber1,
secretNumberRoot,
}),
);
fs.writeFileSync(
tmpdir.resolve('node_modules/pkg/package.json'),
JSON.stringify({
name: 'pkg',
exports: './subfolder/index.js',
secretNumber2,
secretNumberSubfolder,
}),
);

Expand All @@ -124,7 +123,7 @@ describe('findPackageJSON', () => { // Throws when no arguments are provided
tmpdir.resolve('node_modules/pkg/subfolder2/package.json'),
JSON.stringify({
type: 'module',
secretNumber3,
secretNumberSubfolder2,
}),
);
fs.writeFileSync(
Expand All @@ -138,15 +137,15 @@ describe('findPackageJSON', () => { // Throws when no arguments are provided
JSON.stringify({
name: 'pkg',
main: tmpdir.resolve('node_modules/pkg/subfolder2/index.js'),
secretNumber4,
secretNumberPkg2,
}),
);

common.spawnPromisified(process.execPath, [tmpdir.resolve('entry.mjs')]).then(common.mustCall((result) => {
console.error(result.stderr);
console.log(result.stdout);
assert.deepStrictEqual(result, {
stdout: `${secretNumber1} NaN ${secretNumber3} ${secretNumber4}\n`,
stdout: `${secretNumberRoot} undefined ${secretNumberSubfolder2} ${secretNumberPkg2}\n`,
stderr: '',
code: 0,
signal: null,
Expand Down

0 comments on commit 3c86c25

Please sign in to comment.