Add CanCreateRelationshipUseCase and handling of expired RelationshipTemplates

[britsta]

If an App user scans a RelationshipTemplate containing a Request and only responds to the Request after the RelationshipTemplate has expired, no error message is shown. This problem is to be resolved by the Runtime throwing corresponding errors for expired RelationshipTemplates.

In connection with this, the CanCreateRelationshipUseCase has now also been added, in which an error can also be thrown due to an expired RelationshipTemplate.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 78.23834% with 42 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...c/modules/relationships/RelationshipsController.ts	66.66%	18 Missing ⚠️
...s/transport/relationships/CanCreateRelationship.ts	88.23%	6 Missing ⚠️
packages/transport/src/core/TransportCoreErrors.ts	28.57%	5 Missing ⚠️
...ionships/backbone/BackboneCanCreateRelationship.ts	0.00%	4 Missing ⚠️
packages/core-types/src/CoreDate.ts	40.00%	3 Missing ⚠️
...tionshipTemplates/CreateOwnRelationshipTemplate.ts	76.92%	2 Missing and 1 partial ⚠️
...umption/src/modules/requests/local/LocalRequest.ts	85.71%	2 Missing ⚠️
...ases/transport/relationships/CreateRelationship.ts	87.50%	1 Missing ⚠️

Files with missing lines	Coverage Δ
...nsumption/src/consumption/ConsumptionController.ts	96.73% <100.00%> (+0.01%)	⬆️
...es/requests/incoming/IncomingRequestsController.ts	96.65% <100.00%> (+0.09%)	⬆️
...nsibility/facades/transport/RelationshipsFacade.ts	100.00% <100.00%> (ø)
...kages/runtime/src/useCases/common/RuntimeErrors.ts	79.46% <100.00%> (+1.90%)	⬆️
...elationshipTemplates/local/RelationshipTemplate.ts	94.87% <100.00%> (+0.42%)	⬆️
...dules/relationships/backbone/RelationshipClient.ts	100.00% <100.00%> (ø)
...ases/transport/relationships/CreateRelationship.ts	85.71% <87.50%> (+0.80%)	⬆️
...umption/src/modules/requests/local/LocalRequest.ts	93.83% <85.71%> (-0.91%)	⬇️
packages/core-types/src/CoreDate.ts	64.36% <40.00%> (-0.73%)	⬇️
...tionshipTemplates/CreateOwnRelationshipTemplate.ts	82.52% <76.92%> (-1.35%)	⬇️
... and 4 more

... and 1 file with indirect coverage changes

[Magnus-Kuhn]

@britsta There's currently no updating of request expiration in case an accept request or a create relationship (or something like that) fails, it's only updated upon receiving the request. Since you originally put them in, I'd like to ask you specifically if you're fine with that

[britsta]

@britsta There's currently no updating of request expiration in case an accept request or a create relationship (or something like that) fails, it's only updated upon receiving the request. Since you originally put them in, I'd like to ask you specifically if you're fine with that

@Magnus-Kuhn I'm not sure if I understand you quite right regarding the impact of a failing Request acceptance on the expiry update of a Request. What exactly do you mean by that? As I understand it, the Request expiry is still updated anytime when the getIncomingRequest (or getIncomingRequests) method is called. Therefore, especially, in the beginning of the AcceptIncomingRequest use case.

...But no longer, as you correctly said, in the CanCreateRelationship or CreateRelationship use case. @jkoenig134 prefers to remove this side effect from these use cases and that's fine for me, because the status is updated at the next time I call up a Request getter. Even if we could certainly discuss this further... :D

[Magnus-Kuhn]

@britsta I meant that the fact that the template expired was used to update the request - sorry I didn't make that clear

[britsta]

@britsta I meant that the fact that the template expired was used to update the request - sorry I didn't make that clear

No problem! I see, I think it is not necessary anymore if the expiresAt of the Request is set to the minimum of the expiresAt of the RelationshipTemplate and the Request, when the Request is created. Do you see any need to re-add such expiry updates, or would you consider that as redundant as well?

[Magnus-Kuhn]

#212 (comment) There's a discussion here, for me it's alright the way it is.

[jkoenig134]

@Magnus-Kuhn what's the issue here? I called yesterday with @britsta, everything is discussed and done together.

[britsta]

@Magnus-Kuhn what's the issue here? I called yesterday with @britsta, everything is discussed and done together.

That's on me @jkoenig134, I had a few more questions about a previous discussion, which @Magnus-Kuhn answered. All fine for me! 😊