Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused injected controller #343

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

Milena-Czierlinski
Copy link
Contributor

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@Milena-Czierlinski Milena-Czierlinski added the chore Some routine work like updating dependencies label Nov 26, 2024
@jkoenig134
Copy link
Member

Hmmmmm, why is this unused??

@jkoenig134
Copy link
Member

Was there some kind of validation or so?

@Milena-Czierlinski
Copy link
Contributor Author

It was added in #212 . Maybe @britsta used in for some kind of validation and then moved it elsewhere and forgot to remove it. 🤔 And we didn't see it in our review. I am also surprised that we don't get some kind of error.

@Milena-Czierlinski Milena-Czierlinski marked this pull request as ready for review November 26, 2024 17:11
@jkoenig134
Copy link
Member

There's an error popping up?

@Milena-Czierlinski
Copy link
Contributor Author

There's an error popping up?

Where?

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...ases/transport/relationships/CreateRelationship.ts 85.18% <ø> (-0.53%) ⬇️

... and 180 files with indirect coverage changes

@jkoenig134
Copy link
Member

There's an error popping up?

Where?

You wrote I am also surprised that we don't get some kind of error, so you started to talk about an error 😅

@Milena-Czierlinski
Copy link
Contributor Author

Yes, but I said there is no error popping up. And then you asked There is an error popping up?. 😅

I wish there was an error popping up. Do you know why there isn't?

@jkoenig134
Copy link
Member

Oh, lol. Yeah eslint doesn't tracks these kind of unused vars.

@Milena-Czierlinski Milena-Czierlinski merged commit c74ebb5 into main Nov 27, 2024
21 checks passed
@Milena-Czierlinski Milena-Czierlinski deleted the remove-unused-injected-controller branch November 27, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Some routine work like updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants