Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

himalaya: update for v1 #5297

Merged
merged 5 commits into from
Jan 24, 2025
Merged

himalaya: update for v1 #5297

merged 5 commits into from
Jan 24, 2025

Conversation

soywod
Copy link
Contributor

@soywod soywod commented Apr 19, 2024

Description

This PR make the home manager module compatible with Himalaya CLI v1.x.x. It also removes the watcher, as watching is not part of Himalaya anymore (see #5297 (comment)).

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@github-actions github-actions bot added the mail label Apr 19, 2024
@soywod soywod changed the title himalaya: improve service himalaya: make service generic, add xdg desktop entry Apr 20, 2024
Copy link

stale bot commented Jul 26, 2024

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@soywod
Copy link
Contributor Author

soywod commented Jan 2, 2025

The v1.0.0 has been released, and the Nix package is on its way #363649. As soon as it lands on Nix unstable I will open this pull request.

One of the biggest change is the scope: watch and sync moved away from Himalaya into dedicated project Neverest and Mirador. Questions related to systemd units will move there, as soon as I release them.

@soywod soywod changed the title himalaya: make service generic, add xdg desktop entry himalaya: update for v1.0.0 Jan 2, 2025
@soywod soywod changed the title himalaya: update for v1.0.0 himalaya: update for v1.0.0 Jan 2, 2025
@soywod
Copy link
Contributor Author

soywod commented Jan 13, 2025

The v1.1.0 landed on nixpkgs master. I will be able to open this PR as soon as it reaches nixos-unstable:

https://nixpk.gs/pr-tracker.html?pr=373026

@soywod soywod force-pushed the master branch 2 times, most recently from 85d078b to cd28df6 Compare January 24, 2025 05:21
@soywod soywod changed the title himalaya: update for v1.0.0 himalaya: update for v1 Jan 24, 2025
@soywod soywod marked this pull request as ready for review January 24, 2025 05:31
@soywod soywod requested a review from rycee January 24, 2025 05:31
@soywod
Copy link
Contributor Author

soywod commented Jan 24, 2025

@rycee tests fail with a error: Failed to open archive (Source threw exception: error: unable to download 'https://git.sr.ht/~rycee/nmt/archive/v0.5.1.tar.gz': HTTP error 504, is git.sr.ht down?

@rycee
Copy link
Member

rycee commented Jan 24, 2025

@soywod Yeah, unfortunately sourcehut is being DDoSed again: https://status.sr.ht/issues/2025-01-23-git.sr.ht-ddos/

@rycee
Copy link
Member

rycee commented Jan 24, 2025

I tried running the test manually and got this error:

$ nix build -L .#test-himalaya-basic
himalaya.config.toml> 
home-manager-path> created 180 symlinks in user environment
nmt-test-himalaya-basic> Expected home-files/.config/himalaya/config.toml to be same as /nix/store/4pads6q3iy0a4c5n4i6rarg6anv2cxd6-basic-expected.toml but were different:
nmt-test-himalaya-basic> --- actual
nmt-test-himalaya-basic> +++ expected
nmt-test-himalaya-basic> @@ -14,7 +14,7 @@
nmt-test-himalaya-basic>  [accounts."[email protected]".backend.encryption]
nmt-test-himalaya-basic>  type = "tls"
nmt-test-himalaya-basic> -[accounts."[email protected]".folder.aliases]
nmt-test-himalaya-basic> +[accounts."[email protected]".folder.alias]
nmt-test-himalaya-basic>  drafts = "Drafts"
nmt-test-himalaya-basic>  inbox = "Inbox"
nmt-test-himalaya-basic>  sent = "Sent"

@soywod
Copy link
Contributor Author

soywod commented Jan 24, 2025

I tried running the test manually and got this error:

My bad, forgot to push the fix. Done!

@rycee rycee merged commit 8c0671c into nix-community:master Jan 24, 2025
3 checks passed
@rycee
Copy link
Member

rycee commented Jan 24, 2025

Thanks! Merged to master now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants