Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

himalaya: make generated config compatible with himalaya 1.0 #6353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sylonin
Copy link

@Sylonin Sylonin commented Jan 24, 2025

Description

This change will allow the generated config to work with Himalaya 1.0

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

Maintainer CC

@soywod

@github-actions github-actions bot added the mail label Jan 24, 2025
@soywod
Copy link
Contributor

soywod commented Jan 24, 2025

Duplicate of #5297.

Thanks for the effort, I will move some changes you made to the existing PR. Himalaya CLI v1.1.0 landed on nixpkgs unstable, we can finally undraft it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants