Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Port basic report-capable interfaces from *NiWorkflows* #74

Merged
merged 9 commits into from
May 25, 2023

Conversation

oesteban
Copy link
Member

This sidetracks #71 for interfaces with little discussion about whether they can be consider core enough to be maintained within NiReports.

In addition, moves the SimpleBeforeAfter interface into the set of basic interfaces, as it is very often used.

oesteban and others added 7 commits January 29, 2021 10:12
MAINT: Refactor structure of interfaces
DOC: Ensure copyright notice in all headers' comment
DOC: Ensure copyright notice in all headers' comment
ENH: Allow plotting of image rotated to cardinal axes
MAINT: Refactor structure of interfaces
ENH: Allow plotting of image rotated to cardinal axes
MAINT: Replace distutils use, upgrade versioneer
@oesteban oesteban requested review from effigies and mgxd May 25, 2023 13:28
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 43.11% and project coverage change: -0.89 ⚠️

Comparison is base (178f499) 56.01% compared to head (c3f6b5d) 55.13%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   56.01%   55.13%   -0.89%     
==========================================
  Files          19       20       +1     
  Lines        1828     1937     +109     
  Branches      369      381      +12     
==========================================
+ Hits         1024     1068      +44     
- Misses        728      795      +67     
+ Partials       76       74       -2     
Flag Coverage Δ
unittests 55.13% <43.11%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nireports/interfaces/reporting/base.py 43.11% <43.11%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

This sidetracks #71 for interfaces with little discussion about whether
they can be consider core enough to be maintained within NiReports.

In addition, moves the SimpleBeforeAfter interface into the set of basic
interfaces, as it is very often used.
@oesteban oesteban force-pushed the enh/add-simple-before-after branch from c3f6b5d to 60c7539 Compare May 25, 2023 13:30
@oesteban oesteban merged commit 86172a0 into main May 25, 2023
@oesteban oesteban deleted the enh/add-simple-before-after branch May 25, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants