Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DATALAD] Added subdataset #28

Merged
merged 2 commits into from
May 16, 2024
Merged

[DATALAD] Added subdataset #28

merged 2 commits into from
May 16, 2024

Conversation

effigies
Copy link
Member

Starting adding test data to top-level tests/

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.75%. Comparing base (096251d) to head (d1745a3).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   31.75%   31.75%           
=======================================
  Files          24       24           
  Lines        2028     2028           
  Branches      298      298           
=======================================
  Hits          644      644           
  Misses       1374     1374           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo mentioned this pull request May 16, 2024
5 tasks
@tsalo
Copy link
Collaborator

tsalo commented May 16, 2024

I think the "minimal" version needs the boldref-space brain mask: sub-01/func/sub-01_task-mixedgamblestask_run-[01|02]_desc-brain_mask.nii.gz, which the "full" version shouldn't have since func-space outputs weren't requested.

@tsalo tsalo merged commit a29b14e into nipreps:main May 16, 2024
12 checks passed
@effigies effigies deleted the test/dataset branch May 16, 2024 18:26
@effigies
Copy link
Member Author

I don't think the minimal version produces brain masks. I guess that's a bug?

@tsalo
Copy link
Collaborator

tsalo commented May 16, 2024

In the fmriprep docs it says that the file is created: https://fmriprep.org/en/stable/outputs.html#functional-derivatives (see the first admonition)

@tsalo
Copy link
Collaborator

tsalo commented May 16, 2024

Though I don't know if the mask referenced in the docs is in standard space or not. I could have misread it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants