Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test collect_derivatives function #29

Merged
merged 31 commits into from
May 16, 2024
Merged

Test collect_derivatives function #29

merged 31 commits into from
May 16, 2024

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented May 16, 2024

Closes none.

To do

  • Use path to ds000005 subdataset (pending [DATALAD] Added subdataset #28).
  • Fix up tests.
  • Drop functional entities from anatomical transform queries.
  • Should we find BOLD files in other requested output spaces?
  • Should we add a parameter for the IO spec JSON?
    • The reason I think this might be useful is that, if we want nipost workflows to be chainable, users may wish to run a workflow on derivatives from something other than fMRIPrep. For example, I might want to run fMRIPost-AROMA on BOLD data that have been run through another nipost (e.g., fMRIPost-tedana), and that workflow might not name its postprocessed BOLD files desc-preproc.
    • On the other hand, if we let the BIDS filters file and selected BOLD file entities override the IO spec entities, we'll have trouble ignoring functional run-specific entities (e.g., "task", "run") when grabbing anatomical files.

Changes proposed in this pull request

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 24.13793% with 132 lines in your changes missing coverage. Please review.

Project coverage is 32.18%. Comparing base (a29b14e) to head (33b624a).
Report is 7 commits behind head on main.

Files Patch % Lines
src/fmripost_aroma/utils/bids.py 32.25% 58 Missing and 5 partials ⚠️
src/fmripost_aroma/workflows/base.py 8.69% 42 Missing ⚠️
src/fmripost_aroma/interfaces/confounds.py 27.27% 8 Missing ⚠️
src/fmripost_aroma/utils/utils.py 11.11% 8 Missing ⚠️
src/fmripost_aroma/cli/parser.py 0.00% 4 Missing ⚠️
src/fmripost_aroma/config.py 20.00% 4 Missing ⚠️
src/fmripost_aroma/cli/workflow.py 0.00% 2 Missing ⚠️
src/fmripost_aroma/cli/run.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   31.75%   32.18%   +0.42%     
==========================================
  Files          24       25       +1     
  Lines        2028     2116      +88     
  Branches      298      330      +32     
==========================================
+ Hits          644      681      +37     
- Misses       1374     1416      +42     
- Partials       10       19       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo marked this pull request as ready for review May 16, 2024 16:43
@tsalo tsalo merged commit 741c099 into nipreps:main May 16, 2024
11 of 12 checks passed
@tsalo tsalo deleted the testing branch May 16, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant