Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration tools (arokem) #104

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

arokem
Copy link
Collaborator

@arokem arokem commented Apr 13, 2020

Continues the work started in #78

@pull-assistant
Copy link

pull-assistant bot commented Apr 13, 2020

@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #104 into master will decrease coverage by 0.55%.
The diff coverage is 35.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   51.06%   50.51%   -0.56%     
==========================================
  Files          21       22       +1     
  Lines        1218     1263      +45     
  Branches      161      165       +4     
==========================================
+ Hits          622      638      +16     
- Misses        581      610      +29     
  Partials       15       15              
Impacted Files Coverage Δ
dmriprep/utils/register.py 35.55% <35.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d83d50...18f92d9. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Apr 13, 2020

Hello @arokem, Thank you for updating!

Line 79:5: F841 local variable 'transformed' is assigned to but never used
Line 134:1: F811 redefinition of unused 'AffineRegistration' from line 10
Line 137:9: F841 local variable 'nbins' is assigned to but never used
Line 138:9: F841 local variable 'sampling_prop' is assigned to but never used
Line 139:9: F841 local variable 'metric' is assigned to but never used
Line 140:9: F841 local variable 'level_iters' is assigned to but never used
Line 141:9: F841 local variable 'sigmas' is assigned to but never used
Line 142:9: F841 local variable 'factors' is assigned to but never used
Line 143:9: F841 local variable 'pipeline' is assigned to but never used

To test for issues locally, pip install flake8 and then run flake8 dmriprep.

Comment last updated at 2020-09-29 15:30:40 UTC

@arokem arokem force-pushed the registration_tools_arokem branch from 18f92d9 to 04a843e Compare August 17, 2020 15:55
@oesteban
Copy link
Member

My plan is to rebase this on top of #78 after Derek updates that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants