Backport pt. 1 #62
Closed
Backport pt. 1 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is intended to be minimal-to-no structural changes, focusing just on compat drop-ins, API annotations, and beginning some work in gating off transitions that won't run on pre-lollipop. This commit: - Drops in compat* versions wherever possible, while including some local compat implementations as well. - Target annotations on areas that will only be Lollipop+ (for future reference, no logic changes yet) - Using appcompat theming where possible rather than material Future work would focus around fully supporting conditional transitions and vector drawable interactions, taking advantage of android's resource directory versioning for API-dependent resources, and backporting some functionality with new logic (such as circular imageviews).
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
Thanks for all of this work @hzsweers! As discussed elsewhere, please can you resubmit this to the Thanks! |
|
Will do! I'll close this for now and then re-open to that branch after rebasing next week some time. |
nickbutcher
added a commit
that referenced
this pull request
Feb 29, 2016
Backport pt. 1 (continued from #62)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #47. This PR is intended to be minimal-to-no structural and functional changes, focusing just on compat drop-ins, API annotations, and beginning some work in gating off transitions that won't run on pre-lollipop.
This commit:
Future work would focus around fully supporting conditional transitions and vector drawable interactions, taking advantage of android's resource directory versioning for API-dependent resources, and backporting some functionality with new logic (such as circular imageviews).
I know it's a lot, but after spending a lot of time this week trying to pull things apart in a modular way, it just seemed too much to keep track of. I would've started hitting rebase hell and risking unbuildable commits due to missed imports here or there. One approach might be to break it down into smaller components (per-package maybe?). Another idea would be to PR into another branch so that you could introduce the changes slowly. Let me know what you thinkm and sorry again for the large pull diff :/.
Testing-wise, I've been pretty thorough in testing it to make sure things look and behave the same way. I haven't been able to test designer news or product hunt though. DN's API website seems to be down, and PH requires my emailing them first and asking for permission.