Backport pt. 1 (continued from #62) #68
Conversation
|
The old commits should go away if you rebase your |
|
I've just rebased |
This commit is intended to be minimal-to-no structural changes, focusing just on compat drop-ins, API annotations, and beginning some work in gating off transitions that won't run on pre-lollipop. This commit: - Drops in compat* versions wherever possible, while including some local compat implementations as well. - Target annotations on areas that will only be Lollipop+ (for future reference, no logic changes yet) - Using appcompat theming where possible rather than material Future work would focus around fully supporting conditional transitions, taking advantage of android's resource directory versioning for API-dependent resources, and backporting some functionality with new logic (such as circular imageviews, Path, and ArcMotion).
Bug is fixed in the latest support library now
|
Rebased and good to go! |
|
For when you come accross backporting ElasticDragDismiss, keep this in mind! |
|
@Jawnnypoo it should be API 15-friendly in its current state here |
|
Ahh okay. Carry on then! |
| } | ||
|
|
||
| @ColorInt | ||
| public static int getHighlightColor(@NonNull TextView textView, @ColorRes int defaultColor) { |
There was a problem hiding this comment.
nit: defaultColorResId to make it clear it's a resource id.
|
Wow, thank you so so much for all of this work @hzsweers! |
|
pushed some commits so yigit could look into a recyclerview crash I'm seeing all of a sudden, but still going to look into the transparent vs. null and repeated attributes issues you mentioned |
|
Addressed the remaining comments after just disabling the problem code for now to test. |
|
Thanks for all of the changes. Looking good. |
Backport pt. 1 (continued from #62)
|
Is Plaid backported to run on lower android versions? Where from can I download the code and apk for lower android versions? |
|
@niteshkhatri this is just a start, is not fully backported yet |
As discussed in #47 (and continued from #62). This PR is intended to be minimal-to-no structural and functional changes, focusing just on compat drop-ins, API annotations, and beginning some work in gating off transitions that won't run on pre-lollipop.
This commit:
Future work would focus around fully supporting conditional transitions, taking advantage of android's resource directory versioning for API-dependent resources, and backporting some functionality with new logic (such as circular imageviews, transitions, path, arc motion, and ConnectivityManager).
I know it's a lot, but after spending a lot of time this week trying to pull things apart in a modular way, it just seemed too much to keep track of. I would've started hitting rebase hell and risking unbuildable commits due to missed imports here or there. One approach might be to break it down into smaller components (per-package maybe?). Another idea would be to PR into another branch so that you could introduce the changes slowly. Let me know what you thinkm and sorry again for the large pull diff :/.
Testing-wise, I've been pretty thorough in testing it to make sure things look and behave the same way. I haven't been able to test designer news or product hunt though. DN's API website seems to be down, and PH requires my emailing them first and asking for permission.