Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake build system #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add CMake build system #8

wants to merge 1 commit into from

Conversation

Meakk
Copy link

@Meakk Meakk commented Nov 15, 2024

Simplify compilation using CMake.
Added the standard installation step for easy integration by the user.
Also added a missing header required for std::sort

project(spz
DESCRIPTION "A 3D Gaussians format"
LANGUAGES C CXX
VERSION 0.1)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if this version number is ok. It might be useful to add a git tag v0.1 corresponding to this number at some point.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nbutko you didn't answer to this remark. Does version 0.1 ok to you?
Also, it's very important to create a release with a tag version on github so we can track updates on our side and also download source code using URL like https://github.com/nianticlabs/spz/archive/refs/tags/v0.1.tar.gz

Copy link
Collaborator

@nbutko nbutko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants