Remove Listbox
#2142
Merged
Remove Listbox
#2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmgrifter00
requested review from
rajsite,
jattasNI and
vivinkrishna-ni
as code owners
jattasNI
approved these changes
May 31, 2024
vivinkrishna-ni
approved these changes
May 31, 2024
rajsite
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
The
Listboxcomponent was initially implemented with the idea that it would be used as part of theRichTextEditor. However, we pivoted away from that notion and theListboxis not used anywhere (and is not a documented component). Instead of making the necessary changes to allow it to behave properly with not changes that are being introduced it makes more sense to just remove it for now.👩💻 Implementation
Mainly deleting files. Updated a template file to point to FAST export instead of something from the now deleted
Listboxfile.🧪 Testing
N/A
✅ Checklist