-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
# Pull Request ## 🤨 Rationale The `Listbox` component was initially implemented with the idea that it would be used as part of the `RichTextEditor`. However, we pivoted away from that notion and the `Listbox` is not used anywhere (and is not a documented component). Instead of making the necessary changes to allow it to behave properly with not changes that are being introduced it makes more sense to just remove it for now. ## 👩💻 Implementation Mainly deleting files. Updated a template file to point to FAST export instead of something from the now deleted `Listbox` file. ## 🧪 Testing N/A ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [ ] I have updated the project documentation to reflect my changes or determined no changes are needed.
- Loading branch information
1 parent
aca764d
commit ad47a41
Showing
6 changed files
with
9 additions
and
129 deletions.
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@ni-nimble-components-14d07394-b33a-4aa0-9b2b-1a03f1ffa2e9.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "patch", | ||
"comment": "Remove listbox component as it is unused.", | ||
"packageName": "@ni/nimble-components", | ||
"email": "[email protected]", | ||
"dependentChangeType": "patch" | ||
} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
13 changes: 0 additions & 13 deletions
13
packages/nimble-components/src/listbox/tests/listbox.spec.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 0 additions & 51 deletions
51
packages/storybook/src/nimble/listbox/listbox-matrix.stories.ts
This file was deleted.
Oops, something went wrong.