Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parameterizeSpec in nimble-angular #1768

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

mollykreis
Copy link
Contributor

Pull Request

🀨 Rationale

Resolves #1551

The last step of #1551 is to use the new @ni/jasmine-parameterized package in the Angular tests.

πŸ‘©β€πŸ’» Implementation

Replace usages of testCases.forEach in tests to use parameterizeSpec from @ni/jasmine-parameterize instead.

πŸ§ͺ Testing

  • Verified the same number of tests still run & pass

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis
Copy link
Contributor Author

@m-akinc, can you buddy this for me?

@mollykreis mollykreis requested a review from m-akinc January 23, 2024 19:32
@m-akinc m-akinc marked this pull request as ready for review January 23, 2024 23:49
@rajsite rajsite enabled auto-merge (squash) January 24, 2024 01:20
@rajsite rajsite merged commit 384f4d8 into main Jan 24, 2024
10 checks passed
@rajsite rajsite deleted the parameterize-spec-angular branch January 24, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to the parameterize and parameterizeNamedList test helpers
3 participants