Use and export parameterizeNamedList in nimble-angular #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m-akinc, will you buddy this for me? |
m-akinc
approved these changes
Jan 5, 2024
mollykreis
requested review from
rajsite,
jattasNI and
atmgrifter00
as code owners
atmgrifter00
approved these changes
Jan 5, 2024
rajsite
reviewed
Jan 5, 2024
| @@ -1,4 +1,4 @@ | |||
| import { parameterize, parameterizeNamedList } from '../parameterized'; | |||
| import { parameterize, parameterizeNamedList } from './parameterized'; | |||
There was a problem hiding this comment.
The spec file should be in a tests folder so it's omitted from the build
/src/testing/tests/
| @@ -3,6 +3,7 @@ import { ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testin | |||
| import { Router } from '@angular/router'; | |||
There was a problem hiding this comment.
Discussed how the parameterize test helper could be useful in skyline as well and is maybe not good to expose via nimble-components or nimble-angular packages (it's a generic jasmine helper not tied to our components).
Directions discussed:
- Create a separate package in nimble, like @ni/jasmine-parameterized (which is similar to this public package except ours would be in the ni scope)
- Would need typescript compile and jasmine test set-up
- Would actually be neat to run it in node and and in browser, should be generic enough to, the typescript build would need to emit dist/esm and dist/cjs
- Copy and paste the utility to the @ni/nimble-angular/internal-utilities entry point so it isn't part of the publically supported api and make the package later in nimble or the js style guide.
There was a problem hiding this comment.
Moving to draft temporarily until a direction is picked
There was a problem hiding this comment.
In #1738, I am creating a new @ni/jasmine-parameterized package with these utilities. Once that PR is merged, I plan to update this PR to reference the new location of parameterizeNamedList.
1 task
mollykreis
added a commit
that referenced
this pull request
Jan 23, 2024
# Pull Request ## 🤨 Rationale This is part of #1551 Based on [this discussion](#1735 (comment)), we decided to create a new npm package for `jasmine-parameterized` rather than have it be exported from an existing nimble package. ## 👩💻 Implementation - Create a new package called `jasmine-parameterized` that contains the existing `parameterized.ts` and `tests\parameterized.spec.ts` - Add appropriate support files to build, lint, and test the package - Delete `parameterized.ts` and `tests\parameterized.spec.ts` from `nimble-components` - Update the tests in `nimble-components` to use `parameterizeSpec` from `jasmine-parameterized` ## 🧪 Testing - Verified that the jasmine-parameterized tests are run in the pipeline - Verified that the jasmine-parameterized package contains the `dist` directory (without tests), `package.json`, and `README.md` - Verified all nimble-components tests still pass ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [ ] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: Jesse Attas <[email protected]> Co-authored-by: rajsite <[email protected]>
|
I'm closing this PR in favor of #1768 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Resolves #1551
👩💻 Implementation
There were a few changes made here:
parameterizeNamedListinnimble-componentsfromutilities/teststotestingto move it from a private directory to a directory that is intended to be publictestingentry point in thenimble-angularpackage that re-exports the parameterize utilitiesprocessUpdatesandwaitForUpdatesAsyncshould ultimately be exported from the sametestingentry point, but that hasn't been done yet since it is a breaking changeforEachto loop through test cases to useparameterizeNamedListinstead🧪 Testing
Ran the tests and verified the same number of tests are still being run
✅ Checklist