Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sending consent notifications #1891

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Refactor sending consent notifications #1891

merged 2 commits into from
Oct 1, 2024

Commits on Oct 1, 2024

  1. Refactor consent notifications 

    This simplifies how we send the consent notifications to add a method to
the `ConsentNotification` model for sending consent notifications and
reduce the duplication.
    @thomasleese
    thomasleese committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    0d57e02 View commit details
    Browse the repository at this point in the history

  2. Combine consent reminder and request jobs 

    This simplifies the jobs for sending consent reminders and consent
requests by combining the jobs in to one. We're now sending the emails
and texts asynchronously, so it effectively the new single job is only
doing the work to queue all the emails, which will then be sent out in
the background meaning combining the jobs shouldn't have an impact on
performance.
    @thomasleese
    thomasleese committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    eb305f5 View commit details
    Browse the repository at this point in the history