Refactor sending consent notifications #1891
Merged
+313
−250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
consent-notification-send
branch
from
1ab25cd
to
45251a6
Compare
tvararu
approved these changes
Oct 1, 2024
This simplifies how we send the consent notifications to add a method to the `ConsentNotification` model for sending consent notifications and reduce the duplication.
This simplifies the jobs for sending consent reminders and consent requests by combining the jobs in to one. We're now sending the emails and texts asynchronously, so it effectively the new single job is only doing the work to queue all the emails, which will then be sent out in the background meaning combining the jobs shouldn't have an impact on performance.
thomasleese
force-pushed
the
consent-notification-send
branch
from
45251a6
to
eb305f5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors how we send consent notifications (both requests and reminders) in to a method on the
ConsentNotificationmodel which handles creating a record of the notification and sending the notification to all parents, reducing duplicate logic in a number of different jobs.