-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add access token support #71
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Shawn. Thank you for your contribution to our nginx oidc project.
As I said in previous PRs, we are not using Conventional Commits for this project. So I wouldn't use this approach unnecessarily. Please change the commit name.
df76cdd
to
1c0f658
Compare
Hi Ivan! Thank you so much for your time to review the PR in detail. I have addressed your comments as well as the new commit name. Please let me know if there is anything need to be changed. Happy New Year! |
df5d840
to
7817f3b
Compare
7817f3b
to
996a7da
Compare
996a7da
to
916edd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @route443 for your review. Revised them!
Issue:
Description:
access_token
in the NJS code.access_token
in the key/value store as same as the NGINX RP storesid_token
andrefresh_token
.