-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add access token support in the OIDC #3474
feat: Add access token support in the OIDC #3474
Conversation
3e72a42
to
1e07a19
Compare
e2cf2de
to
d86cf30
Compare
252fa10
to
731394d
Compare
af2c3fc
to
bf5fe17
Compare
bf5fe17
to
e30a4b6
Compare
@brianehlert : This PR is one of OIDC enhancements which are discussed in the Slack channel. |
@shawnhankim |
e30a4b6
to
5a3f013
Compare
|
Please let me know if I miss anything about your question. |
38ccd50
to
800590d
Compare
eebcd9e
to
ab03765
Compare
@shawnhankim can you rebase the PR with |
30e4042
to
353d072
Compare
|
Thanks @lucacome for this feedback and letting me know. Addressed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shawnhankim !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much @shawnhankim!
fix: virtual server template for OIDC.AccessTokenEnable
fix: compare OIDC option to enable access token and intercepting error fix: revert
9fd54f5
to
e6af55d
Compare
Codecov Report
@@ Coverage Diff @@
## main #3474 +/- ##
=======================================
Coverage 52.23% 52.23%
=======================================
Files 59 59
Lines 16877 16878 +1
=======================================
+ Hits 8816 8817 +1
Misses 7766 7766
Partials 295 295
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Proposed changes
$access_token
support for authorizing protected resources in the OpenID Connect (OIDC).accessTokenEnable
) to pass$access_token
as authorization header to upstream.Checklist
Before creating a PR, run through this checklist and mark each as complete.