-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating parameters schema and readme #20
base: dev
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Speed look on my phone, but I think you could probably make the schema quite a bit more powerful by using enum
to limit options. Remember that you can also use pattern
to apply regexes to strings too. The more you validate inputs like this, the better..
"outWigStrand": { | ||
"type": "string", | ||
"default": "Stranded", | ||
"description": "Options are Stranded or Unstranded when defining the strandedness of wiggle/bedGraph output", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the enum
option in the schema to limit the options that can be entered if there are only specific valid values.
This can be done via the little settings cog on the right hand side in the nf-core schema build
GUI.
}, | ||
"incompatPrior": { | ||
"type": "integer", | ||
"type": "string", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this meant to be a string?
Tidied up some of the params in the schema that were linked to the old
params.md
pageAlso removed the params link in the
readme.md
PR checklist
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).