Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important! Template update for nf-core/tools v2.10 #141

Merged
merged 7 commits into from
Oct 17, 2023
Merged

Important! Template update for nf-core/tools v2.10 #141

merged 7 commits into from
Oct 17, 2023

Conversation

nf-core-bot
Copy link
Member

Version 2.10 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.10 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v2.10 release page.

@Aratz Aratz mentioned this pull request Oct 17, 2023
Merged
5 tasks
@github-actions
Copy link

github-actions bot commented Oct 17, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 8c4b27d

+| ✅ 156 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in WorkflowDemultiplex.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-17 11:00:28

@Aratz Aratz requested a review from blajoie as a code owner October 17, 2023 07:35
edmundmiller
edmundmiller approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let me fix the README badges.

README.md Outdated Show resolved Hide resolved
lib/WorkflowDemultiplex.groovy Show resolved Hide resolved
@edmundmiller edmundmiller mentioned this pull request Oct 17, 2023
Open
@edmundmiller edmundmiller added this to the 1.4.0 milestone Oct 17, 2023
@edmundmiller edmundmiller merged commit 3340915 into dev Oct 17, 2023
7 checks passed
@edmundmiller edmundmiller deleted the nf-core-template-merge-2.10 branch October 17, 2023 11:18
@Aratz Aratz mentioned this pull request Oct 17, 2023
Closed
@Aratz Aratz mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundmiller edmundmiller edmundmiller approved these changes

@matthdsm matthdsm Awaiting requested review from matthdsm

@blajoie blajoie Awaiting requested review from blajoie blajoie is a code owner

@maxulysse maxulysse Awaiting requested review from maxulysse

@mashehu mashehu Awaiting requested review from mashehu

Assignees

@Aratz Aratz

@edmundmiller edmundmiller

Labels
None yet
Projects
Hackathon: November 2023
Status: Done
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nf-core-bot @edmundmiller @Aratz