Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex does not parse sample names correctly #105

Closed
vitu1 opened this issue Apr 13, 2023 · 2 comments
Closed

Regex does not parse sample names correctly #105

vitu1 opened this issue Apr 13, 2023 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@vitu1
Copy link

vitu1 commented Apr 13, 2023

Description of the bug

Having a SampleSheet.csv that contains Sample_IDs with characters that partly matches the [Undetermined] regex will cause those files to not be recognized as outputs of the BCLCONVERT process

Steps to reproduce:
Edit the SampleSheet.csv that comes with the test dataset by changing the Sample_ID to something like 'Sample-Unspiked'

Example SampleSheet.csv:
[Header]

[Reads]
110

[Settings]

[Data]
Sample_ID,Sample_Name,Description,Sample_Project
Sample-Unspiked,Sample-Unspiked,,

Running the nf-core/demultiplex test with this SampleSheet.csv will cause the error:
Missing output file(s) **[!Undetermined]_S*_R?_00?.fastq.gz expected by process NFCORE_DEMULTIPLEX:DEMULTIPLEX:BCL_DEMULTIPLEX:BCLCONVERT (220422_M11111_0222_000000000-K9H97.1)

Command used and terminal output

No response

Relevant files

No response

System information

No response

@vitu1 vitu1 added the bug Something isn't working label Apr 13, 2023
@matthdsm
Copy link
Collaborator

Hi @vitu1

Thanks for reporting this. Do you have a suggestion how we could make it better? This is a simple glob mind you, not a full regex.

Thanks
M

@Aratz
Copy link
Contributor

Aratz commented Oct 17, 2023

This should be fixed on dev now, see nf-core/modules#3796 and #141 for details.

@Aratz Aratz closed this as completed Oct 17, 2023
@Aratz Aratz added this to the 1.4.0 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants