Add frequencies panel #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshadfield
approved these changes
Jan 15, 2025
joverlee521
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Changes look good to me 👍
This PR currently keeps "Host" as the default coloring, since host species is an important aspect of rabies biology. However, it might be better to change the default coloring to "clade" so that the clades show up by default in the frequencies panel.
I don't feel strongly either way, but I'd vote to not change default coloring since host is important for rabies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Adds a frequencies panel.
Example tree is staged here.
The year 2000 was chosen as the start date for the frequencies panel based on visual inspection of a histogram of the number of sequences available on GenBank that meet our length criteria (greater than 5000bp) over time:
This PR currently keeps "Host" as the default coloring, since host species is an important aspect of rabies biology. However, it might be better to change the default coloring to "clade" so that the clades show up by default in the frequencies panel.
Related issue(s)
Closes #23
Checklist