Plot French Guiana samples by geography #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds new geolocation rules so that samples will plot in French Guiana (rather than France, Europe) on the map. To maintain consistency in country names, this also changes samples that originally had `South America/French Guiana/*/*` to be `South America/French Guiana (France)/*/*`.
Lat/longs for French Guiana were not present in the defaults in `augur/data/lat_longs.tsv`, and so they are added here and exported to the Auspice JSON.
genehack
approved these changes
Jan 13, 2025
jameshadfield
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Haven't tested out the code but (as per slack) I approve of the direction
joverlee521
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR makes samples that were collected in French Guiana plot on the map within French Guiana, rather than Europe, through the following:
region=South Americacountry=French Guiana (France)division=French Guiana (France)Note that changing the country name to
French Guianarather thanFrench Guiana (France)would cause a CyclicGeolocationRulesError as described here.Closes #21
Related issue(s)
#21
nextstrain/augur#1648
Checklist