-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign clades using Troupin et al definitions #20
base: main
Are you sure you want to change the base?
Conversation
Clades are defined based on the "major clades" of Troupin et al 2016: https://journals.plos.org/plospathogens/article?id=10.1371/journal.ppat.1006041
Adds clades as coloring in auspice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example tree looks good - I agree with the decision to first focus on major clade. Have you run this build a few times to have confidence that the clades are consistently found?
Should we set "Clade" as the default coloring in auspice? For now I kept "Host" as the default coloring, because the clade definitions appear along the branches even when "Host" is used as default coloring, allowing the viewer to see both the host species and clade definitions at the same time.
👍 for the current defaults
Future work could... Assign subclades based on definitions in Troupin et al. 2016 and other sources
Worth playing around with but, as we discussed earlier, I'm not convinced that they're phylogenetically stable.
Future work could... Add a frequencies panel using clade definitions
Yes!
Yes, I did run the build multiple times to check for consistency. Initially the bat clade had inconsistency in assignments across runs (i.e., sometimes some bat clade samples were not assigned to any clade). I noticed that the list of "unique mutations" along the branch leading to the bat clade changed a bit from run to run. So I looked to see which of those unique mutations were consistent across all runs, and only included those in the "bat clade" section of the clades.tsv. That resulted in consistent assignment of bat clade samples across runs. |
Description of proposed changes
Assigns clades based on widely used "major clade" definitions in Troupin et al. 2016.
Example tree is staged here
I would appreciate feedback on the following:
Future work could build on these changes to do the following for the rabies analysis:
Addresses #14
Related issue(s)
#14
Checklist