Remove extension on ESM imports #1110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit "auspice-client: Append extension on ESM imports" (7cde839). The reasoning in that commit was that extensions are necessary for Webpack 5. However, this is not entirely accurate - they are only required¹ when using the default for resolve.fullySpecified *and* using "type": "module" package.json. The latter is not true in our case. Notably, removing the exact path for `auspice/src/components/markdownDisplay` allows the usage to be tolerant of filename changes such as TypeScript conversion. ¹ <https://webpack.js.org/configuration/module/#resolvefullyspecified>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This reverts commit "auspice-client: Append extension on ESM imports" (7cde839).
The reasoning in that commit was that extensions are necessary for Webpack 5. However, this is not entirely accurate - they are only required when using the default for resolve.fullySpecified and using "type": "module" package.json. The latter is not true in our case.
Notably, removing the exact path for
auspice/src/components/markdownDisplayallows the usage to be tolerant of filename changes such as TypeScript conversion.Related issue(s)
Unblocks changes such as nextstrain/auspice@ff91cfd
Checklist
/charon/getDatasetrequest blocked to render the custom Auspice splash component