Oropouche blog post #1040
Merged
Oropouche blog post #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
nextstrain-s-oropouche--wy8wpr
nextstrain-bot
temporarily deployed
to
nextstrain-s-oropouche--wy8wpr
nextstrain-bot
temporarily deployed
to
nextstrain-s-oropouche--wy8wpr
nextstrain-bot
temporarily deployed
to
nextstrain-s-oropouche--wy8wpr
nextstrain-bot
temporarily deployed
to
nextstrain-s-oropouche--wy8wpr
jameshadfield
approved these changes
Oct 18, 2024
genehack
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
+1 in general, along with a suggestion to perhaps add a short intro paragraph at the very beginning that explicitly says something like, "we are pleased to announce the availability of a Oropouche phylogeny dataset on Nextstrain.org" and maybe also work in a "we are interested in feedback from Oropouche researchers about any aspects of this data set"
static-site/content/blog/2024-06-18-oropouche-analysis-and-resources.md
Outdated
Show resolved
Hide resolved
| --- | ||
| author: "Miguel Paredes, James Hadfield, John Anderson, Jover Lee, Trevor Bedford" | ||
| date: "2024-10-18" | ||
| title: "Phylogenetic analysis of Oropuche Virus" |
There was a problem hiding this comment.
not sure what the prevailing style is across current blog posts, but I would suggest either title-casing the whole thing, or down-casing "Virus"...
There was a problem hiding this comment.
agreed! I updated this in the most recent commit, and suggestion actually highlighted out to me that "Oropouche" is mispelled above so I went ahead and fixed that. I also added in an intro paragraph as per your suggestion
static-site/content/blog/2024-06-18-oropouche-analysis-and-resources.md
Outdated
Show resolved
Hide resolved
…ources.md Co-authored-by: John SJ Anderson <[email protected]>
…ources.md Co-authored-by: John SJ Anderson <[email protected]>
nextstrain-bot
temporarily deployed
to
nextstrain-s-oropouche--wy8wpr
nextstrain-bot
temporarily deployed
to
nextstrain-s-oropouche--wy8wpr
I don't like including the panel title, legend caret, bar and tabs in screenshots. You can't actually click on these as affordances and they are just distractions in this setting. Additionally, I added "Divergence" to the x axis. It needs to be labeled, while "Date" is obvious.
I like highlighting that there's a specific URL that corresponds to the viz shown in the screenshot. I've added these as "Available as..." to each figure legend. Also, I've cleaned up some of these URLs. For example `p=grid` vs `p=full` will interact strongly with the user's current screen width, eg, you don't want a link to `p=grid` on a phone. Better to just leave these out. Also, the M and S figure is showing separate trees rather than tanglegram. I just removed `dmin=1986-01-01`. This is not what the figure is showing. Unfortunately we don't have a way to directly link to this zoomed clade. If we wanted this we could add an "outbreak" (or something else) clade label, but I don't think it's terribly important. Also, I removed white-space in line endings.
trvrb
approved these changes
Oct 22, 2024
joverlee521
reviewed
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR adds in the blogpost for the new oropouche build as well as the associated images.
preview rendered blog post
Checklist