Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataset images #94

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Add dataset images #94

wants to merge 8 commits into from

Conversation

ivan-aksamentov
Copy link
Member

@ivan-aksamentov ivan-aksamentov commented Sep 28, 2023

Add optional images to datasets.

Sibling PR in software: nextstrain/nextclade#1262

The image.png or image.json file can be added to dataset directory along with the Image field in pathogen.json:

"image": {
    "path": "image.png",
    "source": "nextstrain.org"
},

This allows Nextclade Web to use these images in the UI.

In this PR I copied some of the images from this git version in nextstrain.org:
https://github.com/nextstrain/nextstrain.org/tree/84b5a589b5e819352b52ee6104f1e25fd77bef12/static-site/static/splash_images

Add optional images to datasets.

The image.png or image.json file can be added to dataset directory along with the `Image` field in `pathogen.json`:

```json
"image": {
    "path": "image.png",
    "source": "nextstrain.org"
  },
```

This allows Nextclade Web to use these images in the UI.

In this PR I copied some of the images from this git version in nextstrain.org:
https://github.com/nextstrain/nextstrain.org/tree/84b5a589b5e819352b52ee6104f1e25fd77bef12/static-site/static/splash_images
@ivan-aksamentov ivan-aksamentov deployed to refs/pull/94/merge September 28, 2023 20:37 — with GitHub Actions Active
@ivan-aksamentov ivan-aksamentov deployed to refs/pull/94/merge September 28, 2023 20:56 — with GitHub Actions Active
@ivan-aksamentov ivan-aksamentov deployed to refs/pull/94/merge September 28, 2023 21:22 — with GitHub Actions Active
ivan-aksamentov added a commit to nextstrain/nextclade that referenced this pull request Sep 28, 2023
Display dataset images in lists

Sibling PR in data: nextstrain/nextclade_data#94
@ivan-aksamentov ivan-aksamentov marked this pull request as draft September 28, 2023 21:40
@ivan-aksamentov ivan-aksamentov changed the title feat: add images to datasets Add dataset images Sep 28, 2023
@ivan-aksamentov ivan-aksamentov force-pushed the master branch 7 times, most recently from 95a53e0 to 9170a53 Compare January 22, 2024 12:08
@ivan-aksamentov ivan-aksamentov force-pushed the master branch 7 times, most recently from 9c290a6 to 0615865 Compare January 31, 2024 19:10
@ivan-aksamentov ivan-aksamentov force-pushed the master branch 14 times, most recently from 7fcea3b to b59f2dd Compare February 1, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants