-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Nextclade to Auspice 2.61+ #1555
base: master
Are you sure you want to change the base?
Conversation
Bumps [auspice](https://github.com/nextstrain/auspice) from 2.59.1 to 2.61.2. - [Release notes](https://github.com/nextstrain/auspice/releases) - [Changelog](https://github.com/nextstrain/auspice/blob/master/CHANGELOG.md) - [Commits](nextstrain/auspice@v2.59.1...v2.61.2) --- updated-dependencies: - dependency-name: auspice dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is presumably due to this conditional where we skip the updating of the data behind the entropy panel if the panel's not rendered or off-screen. I'd guess the intersection observer we use to know if it's off-screen isn't working as expected within Nextclade. But it may also be the former if Nextclade doesn't use |
@jameshadfield Wow, thanks! Yes, I've been trying to identify which additional parts of redux state and logic I need to hook up. Will look into it. |
@jameshadfield Alternatively, do you see an easy way to opt out of this optimization and render the entropy always, as before? |
You could change the source code to modify the conditional to |
Fixes build https://github.com/nextstrain/nextclade/actions/runs/11903714964/job/33171209422?pr=1553#step:18:146
This attempts to adjust Nextclade to changes introduced in Auspice 2.61.0 and above.
This involves a few moved files and making sure ts files are included into monkey patching.
Sadly, entropy panel permanently shows "data loading" after any interaction with the tree (e.g. clicking on a branch or using filters)
I made an isolated
/tree-debug
page to reproduce and investigate the issue further:nextclade/packages/nextclade-web/src/pages/tree-debug.tsx
Lines 21 to 34 in 1b7917a