Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: relabel aminoacids when attaching node #1540

Closed
wants to merge 1 commit into from
Closed

feat: relabel aminoacids when attaching node #1540

wants to merge 1 commit into from

Conversation

ivan-aksamentov
Copy link
Member

Followup of: #1526

Additionally to moving clade let's also move "aa" label

@ivan-aksamentov
feat: relabel aminoacids when attaching node
8e864ca 
Followup of: #1526

Additionally to moving clade let's also move "aa" label
@vercel Vercel
Copy link

vercel bot commented Oct 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nextclade ✅ Ready (Inspect) Visit Preview Oct 18, 2024 4:33am

@rneher
Copy link
Member

rneher commented Oct 18, 2024

I believe the aa are handled already:

nextclade/packages/nextclade/src/tree/tree_builder.rs

Line 375 in 8e864ca

set_branch_attrs_aa_labels(&mut new_internal_node);

nextclade/packages/nextclade/src/tree/tree_builder.rs

Line 424 in 8e864ca

set_branch_attrs_aa_labels(target_node_auspice);

@ivan-aksamentov ivan-aksamentov deleted the clade-vs-nearest-node-relabel-aa branch October 29, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivan-aksamentov @rneher