fix(ci): Upload all CLI build outputs #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include hidden files since our sole path pattern is a hidden "file". Apparently this counts even though the files the pattern matches aren't hidden. GitHub made this big breaking change of excluding hidden files without bumping the major version number of actions/upload-artifact.¹ It, rightfully so, caused a ruckus at the time and continues to be a gift that keeps on giving. The only other actions/upload-artifacts usage, in .github/workflows/web.yml, seemingly isn't affected even though the path contains a hidden directory. Perhaps because in that case there are a few more directory components after it? ¹ <https://github.com/actions/upload-artifact/releases/tag/v4.4.0> Resolves: <#1532>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This fixes the CI issue… and reveals another CI issue (and maybe larger issue?) with the merge of #1529: systems without a trust store (like a bare bones Linux container without |
|
Wow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include hidden files since our sole path pattern is a hidden "file". Apparently this counts even though the files the pattern matches aren't hidden.
GitHub made this big breaking change of excluding hidden files without bumping the major version number of actions/upload-artifact.¹ It, rightfully so, caused a ruckus at the time and continues to be a gift that keeps on giving.
The only other actions/upload-artifacts usage, in
.github/workflows/web.yml, seemingly isn't affected even though the path contains a hidden directory. Perhaps because in that case there are a few more directory components after it?
¹ https://github.com/actions/upload-artifact/releases/tag/v4.4.0
Resolves: #1532