CI is broken

[ivan-aksamentov]

First noticed by @tsibley in #1529 (comment)

I tried to make empty commits stemming off master and off release branches, and they both have the same result - the binaries seems to be compiling successfully, but nothing gets copied to the .out dir. This is strange because the release branch definitely got built and released last time. I don't remember changing anything CI-related in a while.

If I try the same things locally, the

CROSS=x86_64-unknown-linux-gnu ./docker/dev br

produces .out/nextclade-x86_64-unknown-linux-gnu as expected.

and

./docker/cross

produces binaries for all platforms as expected:

I might need to clear docker images and retry.

I appreciate any input.

[tsibley]

I diagnosed this back on #1529.

I believe that the bash checks should be met: running with br (build-release) means both BUILD=1 and RELEASE is set, and then CROSS should be set - the env var is provided explicitly when calling the script

Oh, you're totally right. I misread. It seems as if it's either 1) never getting to the cp, as cp would complain if anything was missing or 2) it's getting to the cp just fine, but for some other reason the upload-artifact step isn't seeing .out/.

And writing that out, it just clicked. actions/upload-artifact@v4 made some pretty big breaking changes—I recall from when I upgraded to v4 in other repos—and indeed, here's the one that's biting us now:

With v4.4 and later, hidden files are excluded by default.

We need to set:

include-hidden-files: true

in its params. Maybe also if-no-files-found: error instead of the default of only warning, since it seems like binaries should always be present.

[tsibley]

Oh right, this wasn't purely the upload-artifact 3→4 upgrade either. They made the breaking change for v3 as well. It was a shitshow. Ugh, I'm recalling more than I wanted to now.