refactor(cli): simplify check for completions cli args

nextstrain · Sep 8, 2023 · 0b2ded4 · 0b2ded4
1 parent a8d2436
commit 0b2ded4
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/packages_rs/nextclade-cli/src/cli/nextclade_cli.rs b/packages_rs/nextclade-cli/src/cli/nextclade_cli.rs
@@ -27,13 +27,6 @@ lazy_static! {
   pub static ref SHELLS: Vec<&'static str> = ["bash", "elvish", "fish", "fig", "powershell", "zsh"].to_vec();
 }
 
-pub fn check_shells(value: &str) -> Result<String, Report> {
-  SHELLS
-    .contains(&value)
-    .then_some(value.to_owned())
-    .ok_or_else(|| eyre!("Unknown shell: '{value}'. Possible values: {}", SHELLS.join(", ")))
-}
-
 #[derive(Parser, Debug)]
 #[clap(name = "nextclade")]
 #[clap(author, version)]
@@ -69,7 +62,7 @@ pub enum NextcladeCommands {
   ///
   Completions {
     /// Name of the shell to generate appropriate completions
-    #[clap(value_name = "SHELL", default_value_t = String::from("bash"), value_parser = check_shells)]
+    #[clap(value_name = "SHELL", default_value_t = String::from("bash"), value_parser = SHELLS.clone())]
     shell: String,
   },