Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new clades to phylogenetic #289

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Add new clades to phylogenetic #289

merged 5 commits into from
Nov 14, 2024

Conversation

corneliusroemer
Copy link
Member

@corneliusroemer corneliusroemer commented Nov 14, 2024

Follows #241 as template

@corneliusroemer corneliusroemer changed the title add new clades Add new clades to phylogenetic Nov 14, 2024
@corneliusroemer corneliusroemer marked this pull request as ready for review November 14, 2024 15:04
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really familiar with mpox lineages, but changes look reasonable to me.

I do wonder if it'd be worth it to consolidate the references files such as clade definitions and color ordering between phylogenetic and nextclade workflows.

@corneliusroemer
Copy link
Member Author

Maybe worth, but I'm not going to do it now if I only edit those files twice a year 😄

@corneliusroemer
Copy link
Member Author

I just designated those lineages over at the designation repo so this is just the logical followup that I always have to do: mpxv-lineages/lineage-designation#45

@corneliusroemer corneliusroemer merged commit 2f88ddb into master Nov 14, 2024
5 checks passed
@corneliusroemer corneliusroemer deleted the new-clades branch November 14, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants