Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clade I build #284

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Fix Clade I build #284

merged 2 commits into from
Oct 31, 2024

Conversation

joverlee521
Copy link
Contributor

@joverlee521 joverlee521 commented Oct 31, 2024

Description of proposed changes

Use --query to filter for clade I build since we have migrated to Nextclade v3 that includes clades I, Ia, and Ib.

Related issue(s)

Follow up to #281
Resolves #283

Checklist

Use `--query` to filter to Clade I and children clades since we have
migrated to Nextclade v3 that includes clades I, Ia, and Ib.

Resolves #283
Add an explicit `query` config param to make it clear that this is used
for the `--query` option of `augur filter`.
@joverlee521
Copy link
Contributor Author

@joverlee521
Copy link
Contributor Author

I compared the trial build to the current live build and I'm confident in these changes so I'm going to merge.


Summary of comparison:

The trial build has one extra sequence (PQ221596/23MPX0047C), but all other sequences are the same based on accession. PQ221596 was previously unassigned with Nextclade v2, but is now assigned to clade Ia with Nextclade v3. So inclusion of PQ221596 in the trial build is expected.

I noticed that the trial build clade assignments are slightly different than the live build in tangletree:

Screenshot 2024-10-31 at 11 37 58 AM

I re-ran the build locally and the clade assignments are the same as the live build:

Screenshot 2024-10-31 at 12 20 16 PM

I'm going to attribute this to some stochastic tree building weirdness that is not a result of any changes in this PR.

@joverlee521 joverlee521 merged commit cddd5f2 into master Oct 31, 2024
14 checks passed
@joverlee521 joverlee521 deleted the fix-clade-i branch October 31, 2024 19:31
@victorlin victorlin mentioned this pull request Nov 18, 2024
1 task
@jameshadfield jameshadfield mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phylogenetic: Clade I build failed during filter
2 participants