Use centralized scripts for NCBI Virus #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
victorlin
commented
Aug 30, 2023
subrepo: subdir: "ingest/vendored" merged: "c97df23" upstream: origin: "https://github.com/nextstrain/ingest" branch: "main" commit: "c97df23" git-subrepo: version: "0.4.6" origin: "https://github.com/ingydotnet/git-subrepo" commit: "110b9eb"
`fetch-from-ncbi-virus` from the subrepo is a copy of `fetch-from-genbank` with some extra options. Remove the copy in this repo and update references. The supporting scripts `csv-to-ndjson` and `genbank-url` can also be removed.
victorlin
force-pushed
the
victorlin/update-ingest
branch
from
111020e to
871817b
Compare
joverlee521
approved these changes
Sep 5, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
fetch-from-ncbi-virusfrom the subrepo is a copy offetch-from-genbankwith some extra options. It can be used as-is since the new options are not required. Remove the copy in this repo and update references.The supporting scripts
csv-to-ndjsonandgenbank-urlcan also be removed.Related issue(s)
Testing
nextstrain build --cpus 1 . data/sequences.ndjsonruns locally