-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide BiopythonDeprecationWarnings when reading certain sequence files #1731
base: victorlin/centralize-sequence-read
Are you sure you want to change the base?
Conversation
Suggestion for this elegant solution with version switch is from @tsibley: #1727 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A unit test testing that a variety of fasta's are supported would be cool maybe, we already know that our integration tests catch it, but not unit ones.
63cdf89
to
cc365cb
Compare
945011a
to
b031ce6
Compare
cc365cb
to
8fa862a
Compare
b031ce6
to
74b4f7c
Compare
8fa862a
to
cf5c8be
Compare
74b4f7c
to
5c53256
Compare
cf5c8be
to
fbb56fe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## victorlin/centralize-sequence-read #1731 +/- ##
=====================================================================
Coverage ? 73.05%
=====================================================================
Files ? 79
Lines ? 8333
Branches ? 1700
=====================================================================
Hits ? 6088
Misses ? 1958
Partials ? 287 ☔ View full report in Codecov by Sentry. |
fbb56fe
to
e7ed6a7
Compare
5c53256
to
db6fe9f
Compare
Instead of relying on Biopython's which are subject to change across versions.
Biopython 1.85 shows a deprecation warning when using format='fasta' with files that start with anything but '>'. The warning as-is should not be exposed to Augur users. It is not triggered when reading files with format='fasta-pearson', so this is the easiest thing to do continue accepting such files for Biopython >=1.85. This way, Augur users get consistent, backwards compatible behavior no matter the Biopython version they use.
This reverts "Temporarily disable failing test" (f5323be) which should no longer fail after previous changes.
db6fe9f
to
14534ec
Compare
e7ed6a7
to
42a5b6f
Compare
Description of proposed changes
Biopython 1.85 shows a deprecation warning when using format='fasta' with files that start with anything but '>'.
The warning as-is should not be exposed to Augur users. It is not triggered when reading files with format='fasta-pearson', so this is the easiest thing to do continue accepting such files for Biopython >=1.85.
This way, Augur users get consistent, backwards compatible behavior no matter the Biopython version they use.
Related issue(s)
Fixes #1727
Checklist