Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(plaintext): multiple linebreaks at end #6507

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Fix(plaintext): multiple linebreaks at end #6507

merged 6 commits into from
Oct 9, 2024
+121 −106

Commits on Oct 9, 2024

  1. refactor(EditorFactory): split createEditor in rich and plain variant 

    Use two functions that do one thing
rather than one with a boolean flag.

Simplifies the functions use and signature a lot
in particular since plain and rich editor need different arguments.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    b90a514 View commit details
    Browse the repository at this point in the history

  2. fix(lint): use const arrow function for helper 

    This does not require jsdoc comments.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    576af09 View commit details
    Browse the repository at this point in the history

  3. fix(plaintext): allow adding multiple empty lines at the end 

    Pressing enter three times exits a CodeBlock element by default.
Disable this by setting `exitOnTripleEnter` to false in plaintext editor.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2b815e9 View commit details
    Browse the repository at this point in the history

  4. refactor(Editor): pull check for $editor up 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3e689ee View commit details
    Browse the repository at this point in the history

  5. refactor(Editor): separate rich and plain creation 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    07e4bd0 View commit details
    Browse the repository at this point in the history

  6. test(plaintext) add regression test for newlines 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    995642e View commit details
    Browse the repository at this point in the history