Fix(plaintext): multiple linebreaks at end #6507
Merged
+121
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Includes #6505. |
max-nextcloud
requested review from
juliushaertl
and removed request for
mejo-
max-nextcloud
force-pushed
the
fix/plaintext-linebreaks
branch
from
0d2bc64
to
db052fb
Compare
This was referenced Oct 8, 2024
Use two functions that do one thing rather than one with a boolean flag. Simplifies the functions use and signature a lot in particular since plain and rich editor need different arguments. Signed-off-by: Max <[email protected]>
This does not require jsdoc comments. Signed-off-by: Max <[email protected]>
Pressing enter three times exits a CodeBlock element by default. Disable this by setting `exitOnTripleEnter` to false in plaintext editor. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
fix/plaintext-linebreaks
branch
from
edec5d1
to
995642e
Compare
luka-nextcloud
approved these changes
Oct 9, 2024
juliushaertl
approved these changes
Oct 9, 2024
|
failed cypress tests are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing enter three times exits a
CodeBlockelement by default.Disable this by setting
exitOnTripleEntertofalsein plaintext editor.