-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MediaSettings): jumping on devices/backgrounds switch #12815
Conversation
We can easily remove the jumping when switching between tabs. But there is still a jump on opening a tab for the first time. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can easily remove the jumping when switching between tabs.
Nice, looks great! :)
But there is still a jump on opening a tab for the first time.
Can we have a quick vertical size increase / decrease animation on opening the tab initially (and closing it as well)? We can also use either --animation-slow or --animation-quick for that, whatever looks nicer.
And btw, the first time you switch to the "Backgrounds" tab, there is no left/right animation. Is that an artifact in the screen recording or a bug? |
Sure
If the switch happens too fast after opening the first tab, there is a small glitch — a browser needs some time to load and render quite huge images... You can see it on the Will have a look if we can prevent it. Also, on gif it's a bit more noticeable than in reality |
02d96bc
to
504dbb8
Compare
0f963f9
to
efdd142
Compare
@jancborchardt Updated gif. What do you think? |
7c888d2
to
fec1555
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
afeda7c
to
2f71a33
Compare
Rebased and squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShGKme this looks so damns smooth now, awesome work! 😲
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
TransitionExpandDown
componentTransitionWrapper
, because it is a bit more complex than addingname
and CSSChecked:
🏁 Checklist