-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TopBar): hand raised button animation #12926
Conversation
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The raised hand animation looks good, I like it :D.
Rergarding media settings (not related to this PR but to #12815), there is a space created in devices selector to keep the same height with the other tab. It seems a bit off. Maybe a delimiter to indicate that it slides and that space is not random would be good there.
Making it height-stable was the goal from the design review 🙈
🤔 Can try in a separate PR (not related to raised hand) |
Yes, I want to indicate that in the UI too and not remove it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
@DorraJaouad Like this? |
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist