Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TopBar): hand raised button animation #12926

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 8, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

animation

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The raised hand animation looks good, I like it :D.
Rergarding media settings (not related to this PR but to #12815), there is a space created in devices selector to keep the same height with the other tab. It seems a bit off. Maybe a delimiter to indicate that it slides and that space is not random would be good there.
image

@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 9, 2024

there is a space created in devices selector to keep the same height with the other tab.

Making it height-stable was the goal from the design review 🙈

Maybe a delimiter to indicate that it slides and that space is not random would be good there.

🤔 Can try in a separate PR (not related to raised hand)

@DorraJaouad
Copy link
Contributor

Making it height-stable was the goal from the design review 🙈

Yes, I want to indicate that in the UI too and not remove it

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShGKme ShGKme merged commit f54bad3 into main Aug 9, 2024
46 checks passed
@ShGKme ShGKme deleted the fix/raise-hand-animation branch August 9, 2024 16:17
@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 9, 2024

@DorraJaouad Like this?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants